All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Mamedov <rm@romanrm.net>
To: Robert White <rwhite@pobox.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: Can't cp --reflink files on a Ext4-converted FS w/o checksums
Date: Thu, 27 Nov 2014 05:20:21 +0500	[thread overview]
Message-ID: <20141127052021.47734be0@natsu> (raw)
In-Reply-To: <54766997.1040101@pobox.com>

On Wed, 26 Nov 2014 16:00:23 -0800
Robert White <rwhite@pobox.com> wrote:

> Uh... you may _still_ have no checksums on any of those data extents. 
> They are not going to come back until you write them to a normal file 
> with a normal copy. So you may be lacking most of the data validation 
> features of this filesystem.

Well, this FS is coming from being Ext4 for years, so it's not worse off now
than it was before. And anyways the main feature that I wanted were snapshots.

> You might want to go experiment. Make another new subvol (or at least a 
> directory in a directory/root/subvol that never had the +C attribute 
> set) and see if you can cp --reflink any of these files into that 
> subdirectory without repeating the +C trick.

Ha, indeed I can't. Maybe there should be a way to generate checksums without
rewriting files, just via reading them, then calculating and writing checksum
to metadata.

> Clearing NODATACOW does _not_ clear NODATASUM (at least not on a 
> non-empty file) as near as I can tell, so that directory hierarchy and 
> its subsequent snapshots is likely "less safe" than you think.

The nodatasum flag also isn't accessible via chattr, is it?

-- 
With respect,
Roman

  reply	other threads:[~2014-11-27  0:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 19:55 Can't cp --reflink files on a Ext4-converted FS w/o checksums Roman Mamedov
2014-11-26 23:18 ` Robert White
2014-11-26 23:33   ` Roman Mamedov
2014-11-27  0:00     ` Robert White
2014-11-27  0:20       ` Roman Mamedov [this message]
2014-11-27  0:31         ` Robert White
2014-11-27  0:57           ` Robert White
2014-11-27  0:20     ` Robert White
2014-11-27  0:28       ` Roman Mamedov
2014-11-27  0:45         ` Robert White
2014-11-27  9:27   ` Duncan
2014-11-28  7:12     ` Robert White
2014-11-27  3:31 ` Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141127052021.47734be0@natsu \
    --to=rm@romanrm.net \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=rwhite@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.