All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: robdclark@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: re: drm/atomic: track bitmask of planes attached to crtc
Date: Thu, 27 Nov 2014 09:41:13 +0300	[thread overview]
Message-ID: <20141127064113.GA13026@mwanda> (raw)

Hello Rob Clark,

The patch 1ed2f34b4cc0: "drm/atomic: track bitmask of planes attached
to crtc" from Nov 21, 2014, leads to the following static checker
warning:

	drivers/gpu/drm/drm_atomic.c:368 drm_atomic_set_crtc_for_plane()
	error: 'plane_state' dereferencing possible ERR_PTR()

drivers/gpu/drm/drm_atomic.c
   360  int
   361  drm_atomic_set_crtc_for_plane(struct drm_atomic_state *state,
   362                                struct drm_plane *plane, struct drm_crtc *crtc)
   363  {
   364          struct drm_plane_state *plane_state =
                                        ^^^^^^^^^^^^^
   365                          drm_atomic_get_plane_state(state, plane);
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   366          struct drm_crtc_state *crtc_state;
   367  
   368          if (plane_state->crtc) {
                    ^^^^^^^^^^^^^^^^^
Missing IS_ERR() check.

Also drm_atomic_get_plane_state() has poor error handling.  In
drm_atomic_get_plane_state(), if the call to drm_atomic_get_plane_state()
fails then it leaks memory.

   369                  crtc_state = drm_atomic_get_crtc_state(plane_state->state,
   370                                                         plane_state->crtc);
   371                  if (WARN_ON(IS_ERR(crtc_state)))
   372                          return PTR_ERR(crtc_state);
   373  
   374                  crtc_state->plane_mask &= ~(1 << drm_plane_index(plane));
   375          }
   376  
   377          plane_state->crtc = crtc;
   378  

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2014-11-27  6:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27  6:41 Dan Carpenter [this message]
2014-11-27  9:55 ` drm/atomic: track bitmask of planes attached to crtc Daniel Vetter
2014-11-27 15:54   ` Dan Carpenter
2014-11-27 17:11     ` Daniel Vetter
2014-11-27 20:04       ` Dan Carpenter
2014-11-28 10:39         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141127064113.GA13026@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.