From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Nadav Amit <namit@cs.technion.ac.il>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Generate #UD when memory operand is required
Date: Thu, 27 Nov 2014 15:58:09 +0100 [thread overview]
Message-ID: <20141127145808.GC8120@potion.brq.redhat.com> (raw)
In-Reply-To: <1417009638-7260-1-git-send-email-namit@cs.technion.ac.il>
2014-11-26 15:47+0200, Nadav Amit:
> Certain x86 instructions that use modrm operands only allow memory operand
> (i.e., mod012), and cause a #UD exception otherwise. KVM ignores this fact.
> Currently, the instructions that are such and are emulated by KVM are MOVBE,
> MOVNTPS, MOVNTPD and MOVNTI. MOVBE is the most blunt example, since it may be
> emulated by the host regardless of MMIO.
>
> The fix introduces a new group for handling such instructions, marking mod3 as
> illegal instruction.
>
> Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
> ---
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
(We could remove GroupDual in the future.)
prev parent reply other threads:[~2014-11-27 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 13:47 [PATCH] KVM: x86: Generate #UD when memory operand is required Nadav Amit
2014-11-26 13:48 ` [PATCH kvm-unit-tests] x86: Test illegal movbe Nadav Amit
2014-11-26 13:57 ` Paolo Bonzini
2014-11-26 21:42 ` [PATCH kvm-unit-tests v2] " Nadav Amit
2014-11-26 13:50 ` [PATCH] KVM: x86: Generate #UD when memory operand is required Paolo Bonzini
2014-11-27 14:58 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127145808.GC8120@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=namit@cs.technion.ac.il \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.