All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 5/9] libfslparser: Use self-extractible helper
Date: Thu, 27 Nov 2014 19:19:32 +0100	[thread overview]
Message-ID: <20141127181932.GJ3900@free.fr> (raw)
In-Reply-To: <1416432642-26005-6-git-send-email-jezz@sysmic.org>

J?r?me, All,

On 2014-11-19 22:30 +0100, J?r?me Pouiller spake thusly:
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Ditto the variable re-ordering.

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/libfslparser/libfslparser.mk | 23 ++++-------------------
>  1 file changed, 4 insertions(+), 19 deletions(-)
> 
> diff --git a/package/libfslparser/libfslparser.mk b/package/libfslparser/libfslparser.mk
> index d52b151..b980ba0 100644
> --- a/package/libfslparser/libfslparser.mk
> +++ b/package/libfslparser/libfslparser.mk
> @@ -7,30 +7,15 @@
>  LIBFSLPARSER_VERSION = 3.0.11
>  LIBFSLPARSER_SITE = $(FREESCALE_IMX_SITE)
>  LIBFSLPARSER_SOURCE = libfslparser-$(LIBFSLPARSER_VERSION).bin
> +LIBFSLPARSER_INSTALL_STAGING = YES
> +
> +# See freescale-imx.mk
>  LIBFSLPARSER_LICENSE = Freescale Semiconductor Software License Agreement
>  LIBFSLPARSER_LICENSE_FILES = EULA EULA.txt
> -# This is a legal minefield: the EULA in the bin file specifies that
> -# the Board Support Package includes software and hardware (sic!)
> -# for which a separate license is needed...
>  LIBFSLPARSER_REDISTRIBUTE = NO
>  
> -LIBFSLPARSER_INSTALL_STAGING = YES
> -
> -# The archive is a shell-self-extractor of a bzipped tar. It happens
> -# to extract in the correct directory (libfslparser-x.y.z)
> -# The --force makes sure it doesn't fail if the source dir already exists.
> -# The --auto-accept skips the license check - not needed for us
> -# because we have legal-info
> -# Since the EULA in the bin file differs from the one in the tar file,
> -# extract the one from the bin file as well.
>  define LIBFSLPARSER_EXTRACT_CMDS
> -	awk 'BEGIN      { start=0; } \
> -	     /^EOEULA/  { start = 0; } \
> -	                { if (start) print; } \
> -	     /<<EOEULA/ { start=1; }'\
> -	    $(DL_DIR)/$(LIBFSLPARSER_SOURCE) > $(@D)/EULA
> -	cd $(BUILD_DIR); \
> -	sh $(DL_DIR)/$(LIBFSLPARSER_SOURCE) --force --auto-accept
> +	$(call FREESCALE_IMX_EXTRACT_HELPER,$(DL_DIR)/$(LIBFSLPARSER_SOURCE))
>  endef
>  
>  # The Makefile installs several versions of the libraries, but we only
> -- 
> 1.9.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-11-27 18:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19 21:30 [Buildroot] [PATCH v2 0/9] Better handling of freescale self-extractible binaries Jérôme Pouiller
2014-11-19 21:30 ` [Buildroot] [PATCH v2 1/9] freescale-imx: Add helper to extract " Jérôme Pouiller
2014-11-27 18:13   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 2/9] firmware-imx: Use self-extractible helper Jérôme Pouiller
2014-11-27 18:15   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 3/9] imx-vpu: " Jérôme Pouiller
2014-11-27 18:16   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 4/9] libfslcodec: " Jérôme Pouiller
2014-11-27 18:18   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 5/9] libfslparser: " Jérôme Pouiller
2014-11-27 18:19   ` Yann E. MORIN [this message]
2014-11-19 21:30 ` [Buildroot] [PATCH v2 6/9] libfslvpuwrap: " Jérôme Pouiller
2014-11-27 18:20   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 7/9] gpu-viv-bin-mx6q: " Jérôme Pouiller
2014-11-27 19:22   ` Yann E. MORIN
2014-11-19 21:30 ` [Buildroot] [PATCH v2 8/9] libz160: " Jérôme Pouiller
2014-11-19 21:30 ` [Buildroot] [PATCH v2 9/9] gpu-amd-bin-mx51: " Jérôme Pouiller
2014-11-27 21:29 ` [Buildroot] [PATCH v2 0/9] Better handling of freescale self-extractible binaries Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141127181932.GJ3900@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.