From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Fri, 28 Nov 2014 09:19:05 +0100 Subject: [PATCH] drm: i2c: tda998x: Retry fetching the EDID if it fails first time. In-Reply-To: <546B84C6.3090809@arm.com> References: <546B84C6.3090809@arm.com> Message-ID: <20141128091905.3e491c39@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 18 Nov 2014 17:41:26 +0000 Andrew Jackson wrote: > Fetching the EDID from a connected monitor is an automated thing > with NXP TDA19988. But on some boards the fetching fails for the > first time silently without any indication that an error has occured. > More than that, subsequent fetches of the EDID succeed until the > monitor(s) are unplugged. > > Add a function to validate the read EDID and retry if the block > retrieved is not valid. > > Signed-off-by: Andrew Jackson > Signed-off-by: Liviu Dudau It seems that your patch is deprecated by Laurent Pinchart's [PATCH] drm: tda998x: Use drm_do_get_edid() http://lists.freedesktop.org/archives/dri-devel/2014-November/072906.html -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH] drm: i2c: tda998x: Retry fetching the EDID if it fails first time. Date: Fri, 28 Nov 2014 09:19:05 +0100 Message-ID: <20141128091905.3e491c39@armhf> References: <546B84C6.3090809@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [212.27.42.5]) by gabe.freedesktop.org (Postfix) with ESMTP id D1AFD6E40B for ; Fri, 28 Nov 2014 00:19:13 -0800 (PST) In-Reply-To: <546B84C6.3090809@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrew Jackson Cc: Russell King - ARM Linux , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAxOCBOb3YgMjAxNCAxNzo0MToyNiArMDAwMApBbmRyZXcgSmFja3NvbiA8QW5kcmV3 LkphY2tzb25AYXJtLmNvbT4gd3JvdGU6Cgo+IEZldGNoaW5nIHRoZSBFRElEIGZyb20gYSBjb25u ZWN0ZWQgbW9uaXRvciBpcyBhbiBhdXRvbWF0ZWQgdGhpbmcKPiB3aXRoIE5YUCBUREExOTk4OC4g QnV0IG9uIHNvbWUgYm9hcmRzIHRoZSBmZXRjaGluZyBmYWlscyBmb3IgdGhlCj4gZmlyc3QgdGlt ZSBzaWxlbnRseSB3aXRob3V0IGFueSBpbmRpY2F0aW9uIHRoYXQgYW4gZXJyb3IgaGFzIG9jY3Vy ZWQuCj4gTW9yZSB0aGFuIHRoYXQsIHN1YnNlcXVlbnQgZmV0Y2hlcyBvZiB0aGUgRURJRCBzdWNj ZWVkIHVudGlsIHRoZQo+IG1vbml0b3IocykgYXJlIHVucGx1Z2dlZC4KPiAKPiBBZGQgYSBmdW5j dGlvbiB0byB2YWxpZGF0ZSB0aGUgcmVhZCBFRElEIGFuZCByZXRyeSBpZiB0aGUgYmxvY2sKPiBy ZXRyaWV2ZWQgaXMgbm90IHZhbGlkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBKYWNrc29u IDxBbmRyZXcuSmFja3NvbkBhcm0uY29tPgo+IFNpZ25lZC1vZmYtYnk6IExpdml1IER1ZGF1IDxM aXZpdS5EdWRhdUBhcm0uY29tPgoKSXQgc2VlbXMgdGhhdCB5b3VyIHBhdGNoIGlzIGRlcHJlY2F0 ZWQgYnkgTGF1cmVudCBQaW5jaGFydCdzCglbUEFUQ0hdIGRybTogdGRhOTk4eDogVXNlIGRybV9k b19nZXRfZWRpZCgpCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRl dmVsLzIwMTQtTm92ZW1iZXIvMDcyOTA2Lmh0bWwKCi0tIApLZW4gYXIgYydoZW50YcOxCXwJICAg ICAgKiogQnJlaXpoIGhhIExpbnV4IGF0YXYhICoqCkplZgkJfAkJaHR0cDovL21vaW5lamYuZnJl ZS5mci8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751265AbaK1ITP (ORCPT ); Fri, 28 Nov 2014 03:19:15 -0500 Received: from smtp5-g21.free.fr ([212.27.42.5]:60553 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155AbaK1ITN convert rfc822-to-8bit (ORCPT ); Fri, 28 Nov 2014 03:19:13 -0500 Date: Fri, 28 Nov 2014 09:19:05 +0100 From: Jean-Francois Moine To: Andrew Jackson Cc: Russell King - ARM Linux , Dave Airlie , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Liviu Dudau , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] drm: i2c: tda998x: Retry fetching the EDID if it fails first time. Message-ID: <20141128091905.3e491c39@armhf> In-Reply-To: <546B84C6.3090809@arm.com> References: <546B84C6.3090809@arm.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Nov 2014 17:41:26 +0000 Andrew Jackson wrote: > Fetching the EDID from a connected monitor is an automated thing > with NXP TDA19988. But on some boards the fetching fails for the > first time silently without any indication that an error has occured. > More than that, subsequent fetches of the EDID succeed until the > monitor(s) are unplugged. > > Add a function to validate the read EDID and retry if the block > retrieved is not valid. > > Signed-off-by: Andrew Jackson > Signed-off-by: Liviu Dudau It seems that your patch is deprecated by Laurent Pinchart's [PATCH] drm: tda998x: Use drm_do_get_edid() http://lists.freedesktop.org/archives/dri-devel/2014-November/072906.html -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/