From: Greg KH <gregkh@linuxfoundation.org>
To: "Javier González" <javier@javigon.com>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, joshc@codeaurora.org,
johannes.thumshirn@men.de, kheitke@codeaurora.org,
laurent.pinchart+renesas@ideasonboard.com,
geert+renesas@glider.be, horms+renesas@verge.net.au,
damm@opensource.se, tomi.valkeinen@ti.com, mbohan@codeaurora.org,
michal.simek@xilinx.com, pawel.moll@arm.com,
Andrew.Thoelke@arm.com
Subject: Re: [RFC PATCH 1/3] Add generic TrustZone driver
Date: Fri, 28 Nov 2014 11:15:07 -0800 [thread overview]
Message-ID: <20141128191507.GA7804@kroah.com> (raw)
In-Reply-To: <1417187016-7731-2-git-send-email-javier@javigon.com>
On Fri, Nov 28, 2014 at 04:03:34PM +0100, Javier González wrote:
> From: Javier Gonzalez <javier@javigon.com>
Any reason you sent this twice?
And your code is full of FIXMEs, which implies that you aren't even
happy with the code, so why would we want to review it as-is now?
Please come up with a design, and implementation, that you feel
comfortable with before asking others to do work to review your broken
implementation.
> +static void trustzone_dev_release(struct device *dev)
> +{
> + /* FIXME: You need to fix all this crap... */
Yes you do, why you are asking others to do your work is beyond my
comprehension...
greg k-h
next prev parent reply other threads:[~2014-11-28 19:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 15:03 [RFC PATCH 0/3] Generic TrustZone Driver in Linux Kernel Javier González
2014-11-28 15:03 ` [RFC PATCH 1/3] Add generic TrustZone driver Javier González
2014-11-28 19:15 ` Greg KH [this message]
2014-11-28 21:09 ` Javier González
2014-11-28 22:16 ` Greg KH
2014-11-28 22:41 ` Javier González
2014-11-28 15:03 ` [RFC PATCH 2/3] Open Virtualization driver Javier González
2014-11-28 15:03 ` [RFC PATCH 3/3] TrustZone driver: wrap OV driver Javier González
2014-11-29 18:18 ` [RFC PATCH 0/3] Generic TrustZone Driver in Linux Kernel Jason Cooper
2014-11-29 18:48 ` Greg KH
2014-11-30 12:14 ` Javier González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128191507.GA7804@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Andrew.Thoelke@arm.com \
--cc=damm@opensource.se \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=javier@javigon.com \
--cc=johannes.thumshirn@men.de \
--cc=joshc@codeaurora.org \
--cc=kheitke@codeaurora.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mbohan@codeaurora.org \
--cc=michal.simek@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.