From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v3 1/3] drm: add bus_formats and nbus_formats fields to drm_display_info Date: Sun, 30 Nov 2014 13:39:11 +0100 Message-ID: <20141130133911.2daef8f4@bbrezillon> References: <1416318380-20122-1-git-send-email-boris.brezillon@free-electrons.com> <1416318380-20122-2-git-send-email-boris.brezillon@free-electrons.com> <56712774.y8GaD3rGMh@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by gabe.freedesktop.org (Postfix) with ESMTP id 178946E101 for ; Sun, 30 Nov 2014 04:39:16 -0800 (PST) In-Reply-To: <56712774.y8GaD3rGMh@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans Verkuil , linux-media@vger.kernel.org, Mauro Carvalho Chehab List-Id: dri-devel@lists.freedesktop.org SGkgTGF1cmVudCwKCk9uIFNhdCwgMjkgTm92IDIwMTQgMDA6MTM6NDcgKzAyMDAKTGF1cmVudCBQ aW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPiB3cm90ZToKCj4gSGkg Qm9yaXMsCj4gCj4gVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guIEkganVzdCBoYXZlIHR3byBzbWFs bCBjb21tZW50cy4KPiAKPiBPbiBUdWVzZGF5IDE4IE5vdmVtYmVyIDIwMTQgMTQ6NDY6MTggQm9y aXMgQnJlemlsbG9uIHdyb3RlOgo+ID4gQWRkIGJ1c19mb3JtYXRzIGFuZCBuYnVzX2Zvcm1hdHMg ZmllbGRzIGFuZAo+ID4gZHJtX2Rpc3BsYXlfaW5mb19zZXRfYnVzX2Zvcm1hdHMgaGVscGVyIGZ1 bmN0aW9uIHRvIHNwZWNpZnkgdGhlIGJ1cwo+ID4gZm9ybWF0cyBzdXBwb3J0ZWQgYnkgYSBnaXZl biBkaXNwbGF5Lgo+ID4gCj4gPiBUaGlzIGluZm9ybWF0aW9uIGNhbiBiZSB1c2VkIGJ5IGRpc3Bs YXkgY29udHJvbGxlciBkcml2ZXJzIHRvIGNvbmZpZ3VyZQo+ID4gdGhlIG91dHB1dCBpbnRlcmZh Y2UgYXBwcm9wcmlhdGVseSAoaS5lLiBSR0I1NjUsIFJHQjY2NiBvciBSR0I4ODggb24gcmF3Cj4g PiBSR0Igb3IgTFZEUyBidXNzZXMpLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBCb3JpcyBCcmV6 aWxsb24gPGJvcmlzLmJyZXppbGxvbkBmcmVlLWVsZWN0cm9ucy5jb20+Cj4gPiAtLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyB8IDMwICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwo+ID4gIGluY2x1ZGUvZHJtL2RybV9jcnRjLmggICAgIHwgIDcgKysrKysrKwo+ID4gIDIg ZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ID4g aW5kZXggZTc5YzhkMy4uMTdlM2FjZiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fY3J0Yy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ID4gQEAgLTc2 Myw2ICs3NjMsMzYgQEAgc3RhdGljIHZvaWQgZHJtX21vZGVfcmVtb3ZlKHN0cnVjdCBkcm1fY29u bmVjdG9yCj4gPiAqY29ubmVjdG9yLCBkcm1fbW9kZV9kZXN0cm95KGNvbm5lY3Rvci0+ZGV2LCBt b2RlKTsKPiA+ICB9Cj4gPiAKPiA+ICsvKgo+ID4gKyAqIGRybV9kaXNwbGF5X2luZm9fc2V0X2J1 c19mb3JtYXRzIC0gc2V0IHRoZSBzdXBwb3J0ZWQgYnVzIGZvcm1hdHMKPiA+ICsgKiBAaW5mbzog ZGlzcGxheSBpbmZvIHRvIHN0b3JlIGJ1cyBmb3JtYXRzIGluCj4gPiArICogQGZtdHM6IGFycmF5 IGNvbnRhaW5pbmcgdGhlIHN1cHBvcnRlZCBidXMgZm9ybWF0cwo+ID4gKyAqIEBuZm10czogdGhl IG51bWJlciBvZiBlbnRyaWVzIGluIHRoZSBmbXRzIGFycmF5Cj4gPiArICoKPiA+ICsgKiBTdG9y ZSB0aGUgc3VwcHBvcnRlZCBidXMgZm9ybWF0cyBpbiBkaXNwbGF5IGluZm8gc3RydWN0dXJlLgo+ IAo+IENvdWxkIHlvdSBkb2N1bWVudCB0aGF0IHRoZSBmb3JtYXRzIGFyZSBzcGVjaWZpZWQgYXMg TUVESUFfQlVTX0ZNVF8qIHZhbHVlcyA/CgpTdXJlLCBJJ2xsIGNsZWFybHkgc3RhdGUgdGhhdC4K Cj4gCj4gPiArICovCj4gPiAraW50IGRybV9kaXNwbGF5X2luZm9fc2V0X2J1c19mb3JtYXRzKHN0 cnVjdCBkcm1fZGlzcGxheV9pbmZvICppbmZvLCBjb25zdAo+ID4gdTMyICpmbXRzLCArCQkJCSAg ICAgdW5zaWduZWQgaW50IG51bV9mbXRzKQo+ID4gK3sKPiA+ICsJdTMyICpmb3JtYXRzID0gTlVM TDsKPiA+ICsKPiA+ICsJaWYgKCFmbXRzICYmIG51bV9mbXRzKQo+ID4gKwkJcmV0dXJuIC1FSU5W QUw7Cj4gPiArCj4gPiArCWlmIChmbXRzICYmIG51bV9mbXRzKSB7Cj4gPiArCQlmb3JtYXRzID0g a21lbWR1cChmbXRzLCBzaXplb2YoKmZtdHMpICogbnVtX2ZtdHMsIEdGUF9LRVJORUwpOwo+ID4g KwkJaWYgKCFmb3JtYXRzKQo+ID4gKwkJCXJldHVybiAtRU5PTUVNOwo+ID4gKwl9Cj4gPiArCj4g PiArCWtmcmVlKGluZm8tPmJ1c19mb3JtYXRzKTsKPiA+ICsJaW5mby0+YnVzX2Zvcm1hdHMgPSBm b3JtYXRzOwo+ID4gKwlpbmZvLT5udW1fYnVzX2Zvcm1hdHMgPSBudW1fZm10czsKPiA+ICsKPiA+ ICsJcmV0dXJuIDA7Cj4gPiArfQo+ID4gK0VYUE9SVF9TWU1CT0woZHJtX2Rpc3BsYXlfaW5mb19z ZXRfYnVzX2Zvcm1hdHMpOwo+ID4gKwo+ID4gIC8qKgo+ID4gICAqIGRybV9jb25uZWN0b3JfZ2V0 X2NtZGxpbmVfbW9kZSAtIHJlYWRzIHRoZSB1c2VyJ3MgY21kbGluZSBtb2RlCj4gPiAgICogQGNv bm5lY3RvcjogY29ubmVjdG9yIHRvIHF1d2VyeQo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJt L2RybV9jcnRjLmggYi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gPiBpbmRleCBjNDAwNzBhLi4y ZTBhM2U4IDEwMDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+ID4gKysrIGIv aW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+ID4gQEAgLTMxLDYgKzMxLDcgQEAKPiA+ICAjaW5jbHVk ZSA8bGludXgvaWRyLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L2ZiLmg+Cj4gPiAgI2luY2x1ZGUg PGxpbnV4L2hkbWkuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvbWVkaWEtYnVzLWZvcm1hdC5oPgo+ ID4gICNpbmNsdWRlIDx1YXBpL2RybS9kcm1fbW9kZS5oPgo+ID4gICNpbmNsdWRlIDx1YXBpL2Ry bS9kcm1fZm91cmNjLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fbW9kZXNldF9sb2NrLmg+Cj4g PiBAQCAtMTMwLDYgKzEzMSw5IEBAIHN0cnVjdCBkcm1fZGlzcGxheV9pbmZvIHsKPiA+ICAJZW51 bSBzdWJwaXhlbF9vcmRlciBzdWJwaXhlbF9vcmRlcjsKPiA+ICAJdTMyIGNvbG9yX2Zvcm1hdHM7 Cj4gPiAKPiA+ICsJY29uc3QgdTMyICpidXNfZm9ybWF0czsKPiA+ICsJaW50IG51bV9idXNfZm9y bWF0czsKPiAKPiBBcyB0aGUgbnVtYmVyIG9mIGZvcm1hdHMgaXMgbmV2ZXIgbmVnYXRpdmUsIEkg d291bGQgbWFrZSBpdCBhbiB1bnNpZ25lZCBpbnQuCgpPa2F5LCBJJ2xsIG1ha2UgaXQgYW4gdW5z aWduZWQgaW50LgoKUmVnYXJkcywKCkJvcmlzCgoKLS0gCkJvcmlzIEJyZXppbGxvbiwgRnJlZSBF bGVjdHJvbnMKRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwOi8vZnJl ZS1lbGVjdHJvbnMuY29tCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from down.free-electrons.com ([37.187.137.238]:45906 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751943AbaK3MjQ (ORCPT ); Sun, 30 Nov 2014 07:39:16 -0500 Date: Sun, 30 Nov 2014 13:39:11 +0100 From: Boris Brezillon To: Laurent Pinchart Cc: David Airlie , dri-devel@lists.freedesktop.org, Thierry Reding , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org Subject: Re: [PATCH v3 1/3] drm: add bus_formats and nbus_formats fields to drm_display_info Message-ID: <20141130133911.2daef8f4@bbrezillon> In-Reply-To: <56712774.y8GaD3rGMh@avalon> References: <1416318380-20122-1-git-send-email-boris.brezillon@free-electrons.com> <1416318380-20122-2-git-send-email-boris.brezillon@free-electrons.com> <56712774.y8GaD3rGMh@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Laurent, On Sat, 29 Nov 2014 00:13:47 +0200 Laurent Pinchart wrote: > Hi Boris, > > Thank you for the patch. I just have two small comments. > > On Tuesday 18 November 2014 14:46:18 Boris Brezillon wrote: > > Add bus_formats and nbus_formats fields and > > drm_display_info_set_bus_formats helper function to specify the bus > > formats supported by a given display. > > > > This information can be used by display controller drivers to configure > > the output interface appropriately (i.e. RGB565, RGB666 or RGB888 on raw > > RGB or LVDS busses). > > > > Signed-off-by: Boris Brezillon > > --- > > drivers/gpu/drm/drm_crtc.c | 30 ++++++++++++++++++++++++++++++ > > include/drm/drm_crtc.h | 7 +++++++ > > 2 files changed, 37 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > index e79c8d3..17e3acf 100644 > > --- a/drivers/gpu/drm/drm_crtc.c > > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -763,6 +763,36 @@ static void drm_mode_remove(struct drm_connector > > *connector, drm_mode_destroy(connector->dev, mode); > > } > > > > +/* > > + * drm_display_info_set_bus_formats - set the supported bus formats > > + * @info: display info to store bus formats in > > + * @fmts: array containing the supported bus formats > > + * @nfmts: the number of entries in the fmts array > > + * > > + * Store the suppported bus formats in display info structure. > > Could you document that the formats are specified as MEDIA_BUS_FMT_* values ? Sure, I'll clearly state that. > > > + */ > > +int drm_display_info_set_bus_formats(struct drm_display_info *info, const > > u32 *fmts, + unsigned int num_fmts) > > +{ > > + u32 *formats = NULL; > > + > > + if (!fmts && num_fmts) > > + return -EINVAL; > > + > > + if (fmts && num_fmts) { > > + formats = kmemdup(fmts, sizeof(*fmts) * num_fmts, GFP_KERNEL); > > + if (!formats) > > + return -ENOMEM; > > + } > > + > > + kfree(info->bus_formats); > > + info->bus_formats = formats; > > + info->num_bus_formats = num_fmts; > > + > > + return 0; > > +} > > +EXPORT_SYMBOL(drm_display_info_set_bus_formats); > > + > > /** > > * drm_connector_get_cmdline_mode - reads the user's cmdline mode > > * @connector: connector to quwery > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > index c40070a..2e0a3e8 100644 > > --- a/include/drm/drm_crtc.h > > +++ b/include/drm/drm_crtc.h > > @@ -31,6 +31,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -130,6 +131,9 @@ struct drm_display_info { > > enum subpixel_order subpixel_order; > > u32 color_formats; > > > > + const u32 *bus_formats; > > + int num_bus_formats; > > As the number of formats is never negative, I would make it an unsigned int. Okay, I'll make it an unsigned int. Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com