Re: [PATCH v4 00/15] ST33 I2C TPM driver cleanup

[Christophe RICARD <christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Hi Peter,

Thank you for your feedback (on Sunday :)).

To be honest i missed those warnings. I figured they come when CONFIG_OF
is not set :/.

No problem to send a v5 with tpm/tpm_i2c_stm_st33: Fix potential bug in
tpm_stm_i2c_send and replace r by ret. The purpose here was more to
have a kind of convention inside the driver rather than mixing
r/ret/err.

I hope to send this by tonight.

Best Regards
Christophe

On Sun, 30 Nov 2014 14:37:18 +0100
Peter Hüwe <PeterHuewe-Mmb7MZpHnFY@public.gmane.org> wrote:

> Hi Christophe,
> 
> sorry for the late reply :/
>  
> > This new patchset version is taking into account as much as possible
> > Jason Gunthorpe feedbacks. I hope, i am not missing any.
> > 
> > It still brings:
> > - Some few code clean up from code style up to structure
> > - Device tree support keeping static platform data configuration
> > support.
> > - Fixes & improvement for irq support.
> > - Update the GPLv2 license header
> > 
> > I am also adding the mention Reviewed-By: Jason Gunthorpe
> > <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> on all those patches.
> > Jason, please feel free to let me know if i am mistaking here. :).
> > 
> > This patchset apply on top of James Morris linux-security tree
> 
> Unfortunately I get compile warnings:
> 
> /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.c: In
> function 'tpm_stm_i2c_probe':
> /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.c:748:3:
> warning: passing argument 1 of 'tpm_stm_i2c_of_request_resources'
> from incompatible pointer type [enabled by default]
> /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.c:670:12:
> note: expected 'struct i2c_client *' but argument is of type 'struct
> tpm_chip
> *' /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.c:722:3:
> warning: 'chip' may be used uninitialized in this function
> [-Wuninitialized]
> 
> Smatch complains:
> /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.c:722 
> tpm_stm_i2c_probe() error: potentially dereferencing uninitialized
> 'chip'.
> 
> 
> 
> Can you fix this up?
> 
> (also if you redo the patchset, moving 
> tpm/tpm_i2c_stm_st33: Fix potential bug in tpm_stm_i2c_send
> to the front would be nice, as indicated by Jason on v3
> 
> 
> Nitpick: maybe you could use ret instead of r in your return code
> cleanup. I'm not a fan of one letter variables, except counters)
> 
> 
> Peter
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html