diff for duplicates of <20141201001155.GA11340@bbox> diff --git a/a/1.txt b/N1/1.txt index 0c058de..79deb1c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -52,56 +52,3 @@ Thanks! > pages as well. Make sense. - ->From 2ecc213a2c3634cbee7529055fd6348b03307ed5 Mon Sep 17 00:00:00 2001 -From: Minchan Kim <minchan@kernel.org> -Date: Mon, 1 Dec 2014 09:07:18 +0900 -Subject: [PATCH] mm: remove lock validation check for MADV_FREE - -Curretnly, madvise_free_pte_range is called only madvise path -which already holds an mmap_sem so it's pointless to add the -lock validation check. - -Signed-off-by: Minchan Kim <minchan@kernel.org> ---- - mm/madvise.c | 13 ++----------- - 1 file changed, 2 insertions(+), 11 deletions(-) - -diff --git a/mm/madvise.c b/mm/madvise.c -index dc024effa9bf..6fc9b8298da1 100644 ---- a/mm/madvise.c -+++ b/mm/madvise.c -@@ -275,18 +275,9 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, - - next = pmd_addr_end(addr, end); - if (pmd_trans_huge(*pmd)) { -- if (next - addr != HPAGE_PMD_SIZE) { --#ifdef CONFIG_DEBUG_VM -- if (!rwsem_is_locked(&mm->mmap_sem)) { -- pr_err("%s: mmap_sem is unlocked! addr=0x%lx end=0x%lx vma->vm_start=0x%lx vma->vm_end=0x%lx\n", -- __func__, addr, end, -- vma->vm_start, -- vma->vm_end); -- BUG(); -- } --#endif -+ if (next - addr != HPAGE_PMD_SIZE) - split_huge_page_pmd(vma, addr, pmd); -- } else if (!madvise_free_huge_pmd(tlb, vma, pmd, addr)) -+ else if (!madvise_free_huge_pmd(tlb, vma, pmd, addr)) - goto next; - /* fall through */ - } --- -2.0.0 - - --- -Kind regards, -Minchan Kim - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 046a77d..d01feaa 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -75,59 +75,6 @@ "> madvise path and we are holding mmap_sem and relying on that for regular\n" "> pages as well.\n" "\n" - "Make sense.\n" - "\n" - ">From 2ecc213a2c3634cbee7529055fd6348b03307ed5 Mon Sep 17 00:00:00 2001\n" - "From: Minchan Kim <minchan@kernel.org>\n" - "Date: Mon, 1 Dec 2014 09:07:18 +0900\n" - "Subject: [PATCH] mm: remove lock validation check for MADV_FREE\n" - "\n" - "Curretnly, madvise_free_pte_range is called only madvise path\n" - "which already holds an mmap_sem so it's pointless to add the\n" - "lock validation check.\n" - "\n" - "Signed-off-by: Minchan Kim <minchan@kernel.org>\n" - "---\n" - " mm/madvise.c | 13 ++-----------\n" - " 1 file changed, 2 insertions(+), 11 deletions(-)\n" - "\n" - "diff --git a/mm/madvise.c b/mm/madvise.c\n" - "index dc024effa9bf..6fc9b8298da1 100644\n" - "--- a/mm/madvise.c\n" - "+++ b/mm/madvise.c\n" - "@@ -275,18 +275,9 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr,\n" - " \n" - " \tnext = pmd_addr_end(addr, end);\n" - " \tif (pmd_trans_huge(*pmd)) {\n" - "-\t\tif (next - addr != HPAGE_PMD_SIZE) {\n" - "-#ifdef CONFIG_DEBUG_VM\n" - "-\t\t\tif (!rwsem_is_locked(&mm->mmap_sem)) {\n" - "-\t\t\t\tpr_err(\"%s: mmap_sem is unlocked! addr=0x%lx end=0x%lx vma->vm_start=0x%lx vma->vm_end=0x%lx\\n\",\n" - "-\t\t\t\t\t__func__, addr, end,\n" - "-\t\t\t\t\tvma->vm_start,\n" - "-\t\t\t\t\tvma->vm_end);\n" - "-\t\t\t\tBUG();\n" - "-\t\t\t}\n" - "-#endif\n" - "+\t\tif (next - addr != HPAGE_PMD_SIZE)\n" - " \t\t\tsplit_huge_page_pmd(vma, addr, pmd);\n" - "-\t\t} else if (!madvise_free_huge_pmd(tlb, vma, pmd, addr))\n" - "+\t\telse if (!madvise_free_huge_pmd(tlb, vma, pmd, addr))\n" - " \t\t\tgoto next;\n" - " \t\t/* fall through */\n" - " \t}\n" - "-- \n" - "2.0.0\n" - "\n" - "\n" - "-- \n" - "Kind regards,\n" - "Minchan Kim\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + Make sense. -dee53c82e0a32241ea953d4086d2f96117353ae94c0847b6761db8c5c9bb26fc +a797181f6e29a59ea1088ffc16b2a4f386ff4a040a0883a2496771950c321149
diff --git a/a/1.txt b/N2/1.txt index 0c058de..994dc5f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -99,9 +99,3 @@ index dc024effa9bf..6fc9b8298da1 100644 -- Kind regards, Minchan Kim - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N2/content_digest index 046a77d..cc535fc 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -122,12 +122,6 @@ "\n" "-- \n" "Kind regards,\n" - "Minchan Kim\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + Minchan Kim -dee53c82e0a32241ea953d4086d2f96117353ae94c0847b6761db8c5c9bb26fc +319b2b008a5be9f267b40e21adba7ad995e5cbb3a531a321814b04e3e7e011b8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.