From: Jonathan Corbet <corbet@lwn.net>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: LMML <linux-media@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH v2 06/11] media: marvell-ccic: use vb2_ops_wait_prepare/finish helper
Date: Mon, 1 Dec 2014 14:52:08 -0500 [thread overview]
Message-ID: <20141201145208.228b5d55@lwn.net> (raw)
In-Reply-To: <1417041754-8714-7-git-send-email-prabhakar.csengg@gmail.com>
On Wed, 26 Nov 2014 22:42:29 +0000
"Lad, Prabhakar" <prabhakar.csengg@gmail.com> wrote:
> This patch drops driver specific wait_prepare() and
> wait_finish() callbacks from vb2_ops and instead uses
> the the helpers vb2_ops_wait_prepare/finish() provided
> by the vb2 core
This is good, what I had in mind.
> the lock member of the queue needs
> to be initalized to a mutex so that vb2 helpers
> vb2_ops_wait_prepare/finish() can make use of it.
This is excessive, but not worth worrying about. Thanks for redoing
things.
Acked-by: Jonathan Corbet <corbet@lwn.net>
jon
next prev parent reply other threads:[~2014-12-01 19:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 22:42 [PATCH v2 00/11] media: use vb2_ops_wait_prepare/finish helper Lad, Prabhakar
2014-11-26 22:42 ` [PATCH v2 01/11] media: s3c-camif: " Lad, Prabhakar
2014-12-08 11:04 ` Sylwester Nawrocki
2014-11-26 22:42 ` [PATCH v2 02/11] media: ti-vpe: " Lad, Prabhakar
2014-11-26 22:42 ` [PATCH v2 03/11] media: exynos-gsc: " Lad, Prabhakar
2014-11-26 22:42 ` [PATCH v2 04/11] media: soc_camera: " Lad, Prabhakar
2014-11-26 22:42 ` [PATCH v2 05/11] media: sh_veu: " Lad, Prabhakar
2014-11-26 22:42 ` [PATCH v2 06/11] media: marvell-ccic: " Lad, Prabhakar
2014-12-01 19:52 ` Jonathan Corbet [this message]
2014-11-26 22:42 ` [PATCH v2 07/11] media: s5p-tv: " Lad, Prabhakar
2014-11-26 22:42 ` [PATCH v2 08/11] media: blackfin: " Lad, Prabhakar
2014-11-26 22:42 ` [PATCH v2 09/11] media: s5p-mfc: " Lad, Prabhakar
2014-11-26 22:42 ` [PATCH v2 10/11] media: davinci: vpif_capture: " Lad, Prabhakar
2014-11-26 22:42 ` [PATCH v2 11/11] media: usb: uvc: " Lad, Prabhakar
2014-11-26 22:59 ` Laurent Pinchart
2014-11-26 23:17 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201145208.228b5d55@lwn.net \
--to=corbet@lwn.net \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.