From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@redhat.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Paul E.McKenney" <paulmck@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Waiman Long <Waiman.Long@hp.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] x86, ticketlock: spin_unlock_wait() can livelock
Date: Mon, 1 Dec 2014 22:33:57 +0100 [thread overview]
Message-ID: <20141201213357.GA5834@redhat.com> (raw)
Please review, I'm afraid I could miss something.
OTOH, this almost looks like a bug to me. And in fact I have a bug
report which looks as if spin_unlock_wait() actually spins "forever"
until the system panics, although most probably the are other problems
in kernel/sched which lead to rq->lock contention.
Do we need a barrier() in arch_spin_unlock_wait() ? I guess no, and
the current code doesn't have it.
Perhaps it should use __ticket_lock_spinning() like arch_spin_lock() ?
And probably we should add the lockdep annotations.
Oleg.
next reply other threads:[~2014-12-01 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 21:33 Oleg Nesterov [this message]
2014-12-01 21:34 ` [PATCH 1/1] x86, ticketlock: spin_unlock_wait() can livelock Oleg Nesterov
2014-12-01 21:49 ` Linus Torvalds
2014-12-01 22:09 ` Oleg Nesterov
2014-12-01 22:23 ` Linus Torvalds
2014-12-09 10:17 ` [tip:core/locking] x86/ticketlock: Fix spin_unlock_wait() livelock tip-bot for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201213357.GA5834@redhat.com \
--to=oleg@redhat.com \
--cc=Waiman.Long@hp.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.