From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: kan.liang@intel.com
Cc: jolsa@redhat.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, ak@linux.intel.com
Subject: Re: [PATCH V5 1/1] perf tool:perf diff support for different binaries
Date: Mon, 1 Dec 2014 19:35:41 -0300 [thread overview]
Message-ID: <20141201223541.GM30226@kernel.org> (raw)
In-Reply-To: <1416585348-14762-1-git-send-email-kan.liang@intel.com>
Em Fri, Nov 21, 2014 at 10:55:48AM -0500, kan.liang@intel.com escreveu:
> From: Kan Liang <kan.liang@intel.com>
>
> Currently, the perf diff only works with same binaries. That's because
> it compares the symbol start address. It doesn't work if the perf.data
> comes from different binaries. This patch matches the function names.
>
> Here is a simple examples (Only change f2 and f3 functions location.)
> There is no change in behavior, but the old perf diff display the wrong
> differential profile.
[acme@zoo linux]$ am /wb/1.patch
Applying: perf tool:perf diff support for different binaries
/home/acme/git/linux/.git/rebase-apply/patch:23: trailing whitespace.
If no parameters are passed the samples will be sorted by dso and
symbol.
/home/acme/git/linux/.git/rebase-apply/patch:26: trailing whitespace.
symbols name.
warning: 2 lines add whitespace errors.
[1]+ Stopped am /wb/1.patch
[acme@zoo linux]$
Fixing this up this time.
Please consider:
chmod +x .git/hooks/*
- Arnaldo
next prev parent reply other threads:[~2014-12-01 22:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 15:55 [PATCH V5 1/1] perf tool:perf diff support for different binaries kan.liang
2014-12-01 20:17 ` Jiri Olsa
2014-12-01 22:35 ` Arnaldo Carvalho de Melo [this message]
2014-12-02 15:51 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201223541.GM30226@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.