From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4@vger.kernel.org, Eric Whitney <enwlinux@gmail.com>
Subject: Re: [PATCH] jbd2: fix regression where we fail to initialize checksum seed when loading
Date: Mon, 1 Dec 2014 22:05:55 -0500 [thread overview]
Message-ID: <20141202030555.GA953@thunk.org> (raw)
In-Reply-To: <20141202002223.GT10043@birch.djwong.org>
On Mon, Dec 01, 2014 at 04:22:23PM -0800, Darrick J. Wong wrote:
> When we're enabling journal features, we cannot use the predicate
> jbd2_journal_has_csum_v2or3() because we haven't yet set the sb
> feature flag fields! Moreover, we just finished loading the shash
> driver, so the test is unnecessary; calculate the seed always.
>
> Without this patch, we fail to initialize the checksum seed the first
> time we turn on journal_checksum, which means that all journal blocks
> written during that first mount are corrupt. Transactions written
> after the second mount will be fine, since the feature flag will be
> set in the journal superblock. xfstests generic/{034,321,322} are the
> regression tests.
>
> (This is important for 3.18.)
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.coM>
> Reported-by: Eric Whitney <enwlinux@gmail.com>
Applied, thanks. I've confirmed this has fixed the xfstests
regressions, and I'll be sending this to Linus shortly.
- Ted
prev parent reply other threads:[~2014-12-02 3:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 0:22 [PATCH] jbd2: fix regression where we fail to initialize checksum seed when loading Darrick J. Wong
2014-12-02 3:05 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202030555.GA953@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.