All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: move type conversion functions to xfs_dir.h
Date: Tue, 2 Dec 2014 03:36:26 -0800	[thread overview]
Message-ID: <20141202113626.GA30327@infradead.org> (raw)
In-Reply-To: <1417475883-21881-3-git-send-email-david@fromorbit.com>

On Tue, Dec 02, 2014 at 10:18:03AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> These are currently considered private to libxfs, but they are
> widely used by the userspace code to decode, walk and check
> directory structures. Hence they really form part of the external
> API and as such need to bemoved to xfs_dir2.h.

Lokos good, but why do we need the additional includes in various files?

Signed-off-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-12-02 11:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 23:18 [PATCH 0/2] libxfs: make some dir2 definitions public Dave Chinner
2014-12-01 23:18 ` [PATCH 1/2] xfs: move ftype conversion functions to libxfs Dave Chinner
2014-12-02  9:23   ` Christoph Hellwig
2014-12-01 23:18 ` [PATCH 2/2] xfs: move type conversion functions to xfs_dir.h Dave Chinner
2014-12-02 11:36   ` Christoph Hellwig [this message]
2014-12-02 21:52     ` Dave Chinner
2014-12-03 10:54       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141202113626.GA30327@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.