re: crypto: qat - Intel(R) QAT transport code

[Dan Carpenter <dan.carpenter@oracle.com>]

Hello Tadeusz Struk,

The patch a672a9dc872e: "crypto: qat - Intel(R) QAT transport code"
from Jun 5, 2014, leads to the following static checker warning:

	drivers/crypto/qat/qat_common/adf_transport.c:412 adf_init_bank()
	error: potentially using uninitialized 'coalesc_enabled'.

drivers/crypto/qat/qat_common/adf_transport.c
   407          /* Enable IRQ coalescing always. This will allow to use
   408           * the optimised flag and coalesc register.
   409           * If it is disabled in the config file just use min time value */
   410          if (adf_get_cfg_int(accel_dev, "Accelerator0",
   411                              ADF_ETRMGR_COALESCING_ENABLED_FORMAT,
   412                              bank_num, &coalesc_enabled) && coalesc_enabled)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This condition is reversed, so it only enables coalescing on error.

Probably this feature has not been tested yet.

   413                  adf_enable_coalesc(bank, "Accelerator0", bank_num);
   414          else
   415                  bank->irq_coalesc_timer = ADF_COALESCING_MIN_TIME;
   416  

regards,
dan carpenter