Re: [Qemu-devel] [PATCH v2] qtest/bios-tables: Add DMAR unit test on intel_iommu for q35

[Vasilis Liaskovitis <vliaskov@gmail.com>]

On Mon, Nov 23, 2014 at 04:25:05PM +0200, Marcel Apfelbaum wrote:
> On Mon, 2014-11-24 at 14:37 +0100, Vasilis Liaskovitis wrote:
> > The test enables intel_iommu on q35, looks for and reads the DMAR table as well
> > as its only DRHC structure (for now), checking the header and checksums.
> 
> Hi Vaisilis,
> I had a deeper look to your patch and the code already checks
> header and checksum for DMAR, all you had to do is to add your latest chunk:
> 
> @@ -779,7 +823,7 @@ static void test_acpi_tcg(void)
> >  
> >      memset(&data, 0, sizeof(data));
> >      data.machine = MACHINE_Q35;
> > -    test_acpi_one("-machine q35,accel=tcg", &data);
> > +    test_acpi_one("-machine q35,accel=tcg,iommu=on", &data);
> >      free_test_data(&data);
> 
> You can check that it is automatically done by test_dst_table function.
> You can add there a print to convince yourself.
> 
> However what is missing is a DMAR binary table to compare the content with an expected one.
> You can create it by running:
> tests/acpi-test-data/rebuild-expected-aml.sh
> 
> Then add the newly created file to tests/acpi-test-data/q35/DMAR

sorry for the delay. thanks, I missed this. I sent v3 simply with the addition
of the DMAR aml file and just the "iommu=on" chunk, as you suggested.


- Vasilis