From: Cyril Hrubis <chrubis@suse.cz>
To: "gux.fnst" <gux.fnst@cn.fujitsu.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH v2 1/2] containers: change check_iproute() behavior in netns/netns_helper.h
Date: Tue, 2 Dec 2014 15:12:41 +0100 [thread overview]
Message-ID: <20141202141241.GA18709@rei.suse.de> (raw)
In-Reply-To: <5462BC16.7090709@cn.fujitsu.com>
Hi!
> >> + } else {
> >> + if (cur_ipver < spe_ipver)
> >> + ret = -1;
> >> + else if (cur_ipver == spe_ipver)
> >> + ret = 0;
> >> + else
> >> + ret = 1;
> >> + }
> >
> > Again why bother with return value when all the testcases just needs to
> > know if ip is newer than some version?
> >
>
> I do this in order to provide more choices for users, like tst_kvercmp.
> Is it necessary? If it is not, I will send a new patch. Thanks!
Sorry, I've forgot to answer this one.
I would stick to the simpler version unless there is a need for the more
complex interface. Generally we should do things as simple as possible.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-12-02 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 7:24 [LTP] [PATCH] containers: fix exit status in netns_netlink.c Xing Gu
2014-11-06 8:24 ` Cyril Hrubis
2014-11-10 8:46 ` [LTP] [PATCH v2 1/2] containers: change check_iproute() behavior in netns/netns_helper.h Xing Gu
2014-11-10 8:46 ` [LTP] [PATCH v2 2/2] containers: fix exit status in netns/netns_netlink.c Xing Gu
2014-11-11 13:16 ` [LTP] [PATCH v2 1/2] containers: change check_iproute() behavior in netns/netns_helper.h Cyril Hrubis
[not found] ` <5462BC16.7090709@cn.fujitsu.com>
2014-12-02 14:12 ` Cyril Hrubis [this message]
2014-12-05 7:00 ` [LTP] [PATCH v3 " Xing Gu
2014-12-05 7:00 ` [LTP] [PATCH v3 2/2] containers: fix exit status in netns/netns_netlink.c Xing Gu
2014-12-17 14:36 ` [LTP] [PATCH v3 1/2] containers: change check_iproute() behavior in netns/netns_helper.h Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202141241.GA18709@rei.suse.de \
--to=chrubis@suse.cz \
--cc=gux.fnst@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.