From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] libxl: Fix building libxlu_cfg_y.y with bison 3.0 Date: Tue, 2 Dec 2014 13:32:44 -0500 Message-ID: <20141202183244.GD32385@laptop.dumpdata.com> References: <1417325015-22354-1-git-send-email-eswierk@skyportsystems.com> <1417426933.23604.77.camel@citrix.com> <20141201121955.GB19889@zion.uk.xensource.com> <1417528036.24320.32.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XvsFu-0004GV-8o for xen-devel@lists.xenproject.org; Tue, 02 Dec 2014 18:32:58 +0000 Content-Disposition: inline In-Reply-To: <1417528036.24320.32.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , Ed Swierk , Wei Liu , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Tue, Dec 02, 2014 at 01:47:16PM +0000, Ian Campbell wrote: > On Mon, 2014-12-01 at 12:19 +0000, Wei Liu wrote: > > On Mon, Dec 01, 2014 at 09:42:13AM +0000, Ian Campbell wrote: > > > On Sat, 2014-11-29 at 21:23 -0800, Ed Swierk wrote: > > > > - Use %lex-param instead of obsolete YYLEX_PARAM to override lex scanner > > > > parameter > > > > - Change deprecated %name-prefix= to %name-prefix > > > > > > > > Tested against bison 2.4.1 and 3.0.2. > > > > > > > > Signed-off-by: Ed Swierk > > > > > > Copying Ian J who is the bison guy among the toolstack maintainers. > > > > > > > FWIW I can confirm that libxlu_cfg_y.y won't build in Debian Jessie > > (bison 3.0.2) as is. And this patch fixes the problem for me. > > That would seem like a pretty strong case for 4.5, *except* we ship the > generated files so it should be possible to build anywhere without > requiring any version of bison at all. If Bison is installed then > "./configure BISON=/bin/true" or some such might be needed to stop it > trying to regenerate. > > Konrad, any thoughts. Using the autogenerated one means that it might introduce a bug. However we do allow regeneration of it - and it would be a shame if the auto-generated well, could not be autogenerated! That is a bug, not a major one, but a bug nonethless. It is not a regression thought. The build systems (debian, fedora) all have buildrequires which do not list 'bison' and as such don't encounter this I think - which means it is only encountered by folks who build from the sources - which is a small list. I would lean towards documenting this in the release notes (the work around mentioned above) and defer this to Xen 4.6. > > > > > Wei. > > > > > > --- > > > > tools/libxl/libxlu_cfg_y.y | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/tools/libxl/libxlu_cfg_y.y b/tools/libxl/libxlu_cfg_y.y > > > > index aa9f787..5acd438 100644 > > > > --- a/tools/libxl/libxlu_cfg_y.y > > > > +++ b/tools/libxl/libxlu_cfg_y.y > > > > @@ -17,7 +17,7 @@ > > > > */ > > > > > > > > %{ > > > > -#define YYLEX_PARAM ctx->scanner > > > > +#define ctx_scanner ctx->scanner > > > > #include "libxlu_cfg_i.h" > > > > #include "libxlu_cfg_l.h" > > > > %} > > > > @@ -31,9 +31,9 @@ > > > > %pure-parser > > > > %defines > > > > %error-verbose > > > > -%name-prefix="xlu__cfg_yy" > > > > +%name-prefix "xlu__cfg_yy" > > > > %parse-param { CfgParseContext *ctx } > > > > -%lex-param { void *scanner } > > > > +%lex-param { ctx_scanner } > > > > > > > > %token IDENT STRING NUMBER NEWLINE > > > > %type atom > > > > > > > > > > > > _______________________________________________ > > > Xen-devel mailing list > > > Xen-devel@lists.xen.org > > > http://lists.xen.org/xen-devel > >