From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH for-xen-4.5 1/3] tools/hotplug: distclean target should remove files generated by configure Date: Tue, 2 Dec 2014 13:36:20 -0500 Message-ID: <20141202183620.GE32385@laptop.dumpdata.com> References: <1417533390-29035-1-git-send-email-daniel.kiper@oracle.com> <1417533390-29035-2-git-send-email-daniel.kiper@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XvsJK-0004Ts-Bp for xen-devel@lists.xenproject.org; Tue, 02 Dec 2014 18:36:30 +0000 Content-Disposition: inline In-Reply-To: <1417533390-29035-2-git-send-email-daniel.kiper@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Daniel Kiper Cc: keir@xen.org, ian.campbell@citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Tue, Dec 02, 2014 at 04:16:28PM +0100, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper This usage scenario which I can see this being useful (and I've tripped over this) is when you rebuild a new version from the same repo. As in, this affects developers, but not end-users and not distros. But perhaps I am missing one scenario? As such I would lean towards deferring this (and the other two) to Xen 4.6. Thank you! > --- > tools/Makefile | 3 +++ > tools/hotplug/Makefile | 5 ++++- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tools/Makefile b/tools/Makefile > index af9798a..19b24f3 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -261,6 +261,9 @@ subdir-all-debugger/kdd: .phony > subdir-distclean-firmware: .phony > $(MAKE) -C firmware distclean > > +subdir-distclean-hotplug: .phony > + $(MAKE) -C hotplug distclean > + > subtree-force-update: > ifeq ($(CONFIG_QEMU_XEN),y) > $(MAKE) qemu-xen-dir-force-update > diff --git a/tools/hotplug/Makefile b/tools/hotplug/Makefile > index 14ae9a8..a29a522 100644 > --- a/tools/hotplug/Makefile > +++ b/tools/hotplug/Makefile > @@ -6,5 +6,8 @@ SUBDIRS-$(CONFIG_NetBSD) += NetBSD > SUBDIRS-$(CONFIG_Linux) += Linux > SUBDIRS-$(CONFIG_FreeBSD) += FreeBSD > > -.PHONY: all clean install > +.PHONY: all clean distclean install > all clean install: %: subdirs-% > + > +distclean: > + rm -f Linux/init.d/sysconfig.xencommons Linux/init.d/xencommons NetBSD/rc.d/xencommons > -- > 1.7.10.4 >