All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe MacDonald <Joe_MacDonald@mentor.com>
To: Bruce Ashfield <bruce.ashfield@windriver.com>
Cc: "yocto@yoctoproject.org" <yocto@yoctoproject.org>
Subject: Re: [PATCH 0/2] Add some recipes
Date: Tue, 2 Dec 2014 15:17:25 -0500	[thread overview]
Message-ID: <20141202201724.GE12784@mentor.com> (raw)
In-Reply-To: <547E17B2.6090502@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 4570 bytes --]

[Re: [yocto] [PATCH 0/2] Add some recipes] On 14.12.02 (Tue 14:49) Bruce Ashfield wrote:

> On 14-12-02 02:37 PM, Joe MacDonald wrote:
> >[Re: [yocto] [PATCH 0/2] Add some recipes] On 14.12.02 (Tue 14:03) Alexandru Vaduva wrote:
> >
> >>Hello Bian,
> >>
> >>Did you know that the multipath tools recipe was also available inside the
> >>meta-oe and meta-virtualization?
> >>I do not have any problems with it being available in meta-cgl.  I just wanted
> >>to hear other opinions because I would like to make sure we do not get to that
> >>point where we keep various versions of various recipes in a variety of places.
> >>It will be a nightmare to work with them in the future.
> >
> >I completely agree, and I that's mostly the consensus of the community.
> >Since meta-cgl already has dependencies on both meta-virtualization and
> >meta-oe, I think it makes the most sense to try to keep updates for the
> >multipath recipes in one or both of those layers.  My recommendation
> >would be to update the meta-oe one as it has broader applicability, but
> >of course that's up to the submitter and the layer maintainers to
> >decide.  It may be that it's appropriate to maintain a bbappend for the
> >recipe in meta-cgl, but I think it'd be good to send it for inclusion in
> >meta-oe first.
> 
> I'm with Joe on this one.
> 
> I only did a really quick check on the history of the two copies
> that we have, but I see the meta-virt variant was added in January 2013
> and what could be the first version in meta-oe in March the same year.

I actually intended to say "update the meta-oe one as it has broader
applicability and if you're feeling ambitious, send the same update to
meta-virtualization" since I thought meta-virt didn't have dependencies
on meta-oe and I can see an argument in favour of keeping a separate
recipe if you're keeping the layer contained.  But it looks like that's
not the case, so consolidation makes sense here.

> The layer index may not have been as helpful back then (but honestly
> I can't recall) .. either way we failed to coordinate as a wider community
> and managed to end up with two different recipes in the layers.
> 
> There's no sense making this any worse than it already is, so I'd say
> that we could spend the time looking at the two (three?) recipes, and
> get a consolidated variant in meta-oe, and I'd be happy to drop the
> one in meta-virtualization and bbappend the same way that Joe suggests.
> 
> Thoughts ? We should figure out if someone is going to take a crack
> at it, so we don't all go do the same thing :)

It's not on my to-do list, so don't worry about me running in parallel.
iscsi was (and is again) the only meta-networking one and libcap-ng (as
discussed with Armin the other day) and swig are the meta-selinux ones.

-J.

> 
> Bruce
> 
> 
> 
> >
> >Just my thoughts on it.
> >-J.
> >
> >>Once again, just to make it clear. I am ok with the patches, I will merge all
> >>three of them (corosync, multipath and drbd) but I just wanted to make sure you
> >>took this into consideration.
> >>Also I like the idea of having drbd recipe inside and the fact that you like to
> >>get involved in this initiative.
> >>Hope to hear more from you and also that I will be able to help more.
> >>
> >>
> >>Alex Vaduva
> >>
> >>
> >>On Tuesday, December 2, 2014 10:07 AM, Bian Naimeng <biannm@cn.fujitsu.com>
> >>wrote:
> >>
> >>
> >>Bian Naimeng (2):
> >>   [meta-cgl] device-mapper-multipath: add recipe
> >>   [meta-cgl]drbd: add recipe
> >>
> >>.../device-mapper-multipath/multipathd.init.patch  | 12 +++++
> >>.../device-mapper-multipath_0.5.0.bb              | 53 ++++++++++++++++++++
> >>meta-cgl-common/recipes-cgl/drbd/drbd/drbd.service | 12 +++++
> >>meta-cgl-common/recipes-cgl/drbd/drbd_8.4.4.bb    | 57 ++++++++++++++++++++++
> >>4 files changed, 134 insertions(+)
> >>create mode 100644 meta-cgl-common/recipes-cgl/device-mapper-multipath/
> >>device-mapper-multipath/multipathd.init.patch
> >>create mode 100644 meta-cgl-common/recipes-cgl/device-mapper-multipath/
> >>device-mapper-multipath_0.5.0.bb
> >>create mode 100644 meta-cgl-common/recipes-cgl/drbd/drbd/drbd.service
> >>create mode 100644 meta-cgl-common/recipes-cgl/drbd/drbd_8.4.4.bb
> >>
> >>--
> >>1.9.1
> >>
> >>--
> >>_______________________________________________
> >>yocto mailing list
> >>yocto@yoctoproject.org
> >>https://lists.yoctoproject.org/listinfo/yocto
> >>
> >>
> >
> >
> >
> 

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 501 bytes --]

  reply	other threads:[~2014-12-02 20:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02  8:03 [PATCH 0/2] Add some recipes Bian Naimeng
2014-12-02  8:03 ` [PATCH 1/2] [meta-cgl] device-mapper-multipath: add recipe Bian Naimeng
2014-12-02  8:03 ` [PATCH 2/2] [meta-cgl]drbd: " Bian Naimeng
2014-12-02 14:03 ` [PATCH 0/2] Add some recipes Alexandru Vaduva
2014-12-02 19:37   ` Joe MacDonald
2014-12-02 19:41     ` Joe MacDonald
2014-12-02 19:49     ` Bruce Ashfield
2014-12-02 20:17       ` Joe MacDonald [this message]
2014-12-02 20:32         ` Bruce Ashfield
2014-12-02 20:48           ` Alexandru Vaduva
2014-12-03  2:15             ` Joe MacDonald
2014-12-04  2:22               ` Bian, Naimeng
2014-12-02 15:54 ` akuster808
2014-12-02 19:21   ` Alexandru Vaduva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141202201724.GE12784@mentor.com \
    --to=joe_macdonald@mentor.com \
    --cc=bruce.ashfield@windriver.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.