From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [v8][PATCH 15/17] xen:vtd: create RMRR mapping Date: Tue, 2 Dec 2014 15:30:55 -0500 Message-ID: <20141202203055.GM357@laptop.dumpdata.com> References: <1417425875-9634-1-git-send-email-tiejun.chen@intel.com> <1417425875-9634-16-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1417425875-9634-16-git-send-email-tiejun.chen@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tiejun Chen Cc: kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org On Mon, Dec 01, 2014 at 05:24:33PM +0800, Tiejun Chen wrote: > intel_iommu_map_page() does nothing if VT-d shares EPT page table. > So rmrr_identity_mapping() never create RMRR mapping but in some s/So// s/create/creates/ > cases like some GFX drivers it still need to access RMRR. s/drivers .../drivers which may need to access RMRR/ > > Here we will create those RMRR mappings even in shared EPT case. > > Signed-off-by: Tiejun Chen > --- > xen/drivers/passthrough/vtd/iommu.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c > index a38f201..a54c6eb 100644 > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1856,10 +1856,15 @@ static int rmrr_identity_mapping(struct domain *d, bool_t map, > > while ( base_pfn < end_pfn ) > { > - int err = intel_iommu_map_page(d, base_pfn, base_pfn, > - IOMMUF_readable|IOMMUF_writable); > - > - if ( err ) > + int err = 0; > + if ( iommu_use_hap_pt(d) ) > + { > + ASSERT(!iommu_passthrough || !is_hardware_domain(d)); > + if ( (err = set_identity_p2m_entry(d, base_pfn, p2m_access_rw)) ) > + return err; > + } > + else if ( (err = intel_iommu_map_page(d, base_pfn, base_pfn, > + IOMMUF_readable|IOMMUF_writable)) ) > return err; > base_pfn++; > } > -- > 1.9.1 >