All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Ashley Lai <ashley@ashleylai.com>,
	Marcel Selhorst <tpmdd@selhorst.net>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	josh.triplett@intel.com, christophe.ricard@gmail.com,
	jason.gunthorpe@obsidianresearch.com, linux-api@vger.kernel.org,
	trousers-tech@lists.sourceforge.net
Subject: Re: [PATCH v8 7/8] tpm: TPM 2.0 CRB Interface
Date: Wed, 3 Dec 2014 00:10:33 +0100	[thread overview]
Message-ID: <201412030010.33869.PeterHuewe@gmx.de> (raw)
In-Reply-To: <1417559480-13757-8-git-send-email-jarkko.sakkinen@linux.intel.com>

Am Dienstag, 2. Dezember 2014, 23:31:19 schrieb Jarkko Sakkinen:
> tpm_crb is a driver for TPM 2.0 Command Response Buffer (CRB) Interface
> as defined in PC Client Platform TPM Profile (PTP) Specification.
> 
> Only polling and single locality is supported as these are the limitations
> of the available hardware, Platform Trust Techonlogy (PTT) in Haswell
> CPUs.
> 
> The driver always applies CRB with ACPI start because PTT reports using
> only ACPI start as start method but as a result of my testing it requires
> also CRB start.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> ---

If I apply it on top of security/next or linux-3.18-rc6 I get the following 
compile error:

drivers/char/tpm/tpm_crb.c: In function 'crb_acpi_add':
drivers/char/tpm/tpm_crb.c:271:6: error: too many arguments to function 
'acpi_device_hid'
In file included from include/linux/acpi.h:43:0,
                 from drivers/char/tpm/tpm_crb.c:18:
include/acpi/acpi_bus.h:253:13: note: declared here
drivers/char/tpm/tpm_crb.c:271:6: error: too few arguments to function 
'strcmp'
scripts/Makefile.build:263: recipe for target 'drivers/char/tpm/tpm_crb.o' 
failed
make[3]: *** [drivers/char/tpm/tpm_crb.o] Error 1
scripts/Makefile.build:402: recipe for target 'drivers/char/tpm' failed
make[2]: *** [drivers/char/tpm] Error 2
scripts/Makefile.build:402: recipe for target 'drivers/char' failed
make[1]: *** [drivers/char] Error 2
Makefile:937: recipe for target 'drivers' failed


Please compile test your stuff.

;-(
Peter

  parent reply	other threads:[~2014-12-02 23:10 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 22:31 [PATCH v8 0/8] TPM 2.0 support Jarkko Sakkinen
2014-12-02 22:31 ` Jarkko Sakkinen
     [not found] ` <1417559480-13757-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-12-02 22:31   ` [PATCH v8 1/8] tpm: merge duplicate transmit_cmd() functions Jarkko Sakkinen
2014-12-02 22:31     ` Jarkko Sakkinen
2014-12-02 22:55   ` [PATCH v8 0/8] TPM 2.0 support Peter Hüwe
2014-12-02 22:55     ` Peter Hüwe
     [not found]     ` <201412022355.34544.PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
2014-12-03 10:10       ` Jarkko Sakkinen
2014-12-03 10:10         ` Jarkko Sakkinen
2014-12-02 23:16   ` Peter Hüwe
2014-12-02 23:16     ` Peter Hüwe
     [not found]     ` <201412030016.20268.PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
2014-12-02 23:21       ` [tpmdd-devel] " Peter Hüwe
2014-12-02 23:21         ` Peter Hüwe
     [not found]         ` <201412030021.07882.PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
2014-12-02 23:24           ` Aaro Koskinen
2014-12-02 23:24             ` Aaro Koskinen
     [not found]             ` <20141202232442.GB14524-+UqvGBo8NkiJ/SmVcN9c7yH8jP4CeeTLqBW4ids5wwA@public.gmane.org>
2014-12-02 23:33               ` Peter Hüwe
2014-12-02 23:33                 ` Peter Hüwe
2014-12-02 23:48                 ` Joe Perches
2014-12-03  0:03           ` Thomas Gleixner
2014-12-03  0:03             ` Thomas Gleixner
2014-12-04  5:52       ` Jarkko Sakkinen
2014-12-04  5:52         ` Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 2/8] tpm: two-phase chip management functions Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 3/8] tpm: fix raciness of PPI interface lookup Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 4/8] tpm: rename chip->dev to chip->pdev Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 5/8] tpm: device class for tpm Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 6/8] tpm: TPM 2.0 baseline support Jarkko Sakkinen
     [not found]   ` <1417559480-13757-7-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-12-03  2:21     ` [tpmdd-devel] " Stefan Berger
2014-12-03  2:21       ` Stefan Berger
2014-12-03  2:28   ` Stefan Berger
     [not found]     ` <547E7553.2050608-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2014-12-04 23:13       ` Peter Hüwe
2014-12-04 23:13         ` Peter Hüwe
     [not found]         ` <201412050013.19082.PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
2014-12-08 13:56           ` Jarkko Sakkinen
2014-12-08 13:56             ` Jarkko Sakkinen
     [not found]             ` <20141208135615.GC30303-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-08 16:18               ` peterhuewe-Mmb7MZpHnFY
2014-12-08 16:18                 ` peterhuewe
2014-12-02 22:31 ` [PATCH v8 7/8] tpm: TPM 2.0 CRB Interface Jarkko Sakkinen
     [not found]   ` <1417559480-13757-8-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-12-02 23:07     ` [tpmdd-devel] " Stefan Berger
2014-12-02 23:07       ` Stefan Berger
2014-12-02 23:10   ` Peter Hüwe [this message]
2014-12-02 22:31 ` [PATCH v8 8/8] tpm: TPM 2.0 FIFO Interface Jarkko Sakkinen
  -- strict thread matches above, loose matches on Subject: below --
2014-12-04  5:49 [PATCH v9 0/8] TPM 2.0 support Jarkko Sakkinen
2014-12-04  5:49 ` [PATCH v8 7/8] tpm: TPM 2.0 CRB Interface Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201412030010.33869.PeterHuewe@gmx.de \
    --to=peterhuewe@gmx.de \
    --cc=ashley@ashleylai.com \
    --cc=christophe.ricard@gmail.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jason.gunthorpe@obsidianresearch.com \
    --cc=josh.triplett@intel.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    --cc=trousers-tech@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.