All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Anjana Sasindran <anjanasasindran123@gmail.com>
Cc: soren.brinkmann@xilinx.com, laurent.pinchart@ideasonboard.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration
Date: Tue, 2 Dec 2014 16:37:57 -0800	[thread overview]
Message-ID: <20141203003757.GA3253@kroah.com> (raw)
In-Reply-To: <1417265730-5489-1-git-send-email-anjanasasindran123@gmail.com>

On Sat, Nov 29, 2014 at 06:25:30PM +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning
> 
> WARNING:Missing a blank line after declaration
> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
> ---
>  drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> index 7202d8e..5fa813d 100644
> --- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> +++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> @@ -234,6 +234,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
>  	/* register div per output */
>  	for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
>  		const char *clkout_name;
> +		
>  		if (of_property_read_string_index(np, "clock-output-names", i,
>  						  &clkout_name)) {
>  			dev_err(&pdev->dev,
> -- 
> 1.9.1

ALWAYS run your patches through checkpatch.pl so you don't get angry
emails from maintainers telling you that you added a warning with a
patch you were trying to get applied to remove a warning, making this a
pointless exercise :(

greg k-h

      parent reply	other threads:[~2014-12-03  0:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-29 12:55 [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration Anjana Sasindran
2014-11-30 18:12 ` Sören Brinkmann
2014-12-03  0:37 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203003757.GA3253@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=anjanasasindran123@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=soren.brinkmann@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.