All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Fred <fred.chou.nd@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c
Date: Tue, 2 Dec 2014 16:54:07 -0800	[thread overview]
Message-ID: <20141203005407.GA4433@kroah.com> (raw)
In-Reply-To: <1417398885-27038-1-git-send-email-fred.chou.nd@gmail.com>

On Mon, Dec 01, 2014 at 09:54:45AM +0800, Fred wrote:
> Fixed the following warnings in sparse:
> drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
>  	symbol 'dump_eprom' was not declared.
> 	Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
>  	symbol 'ComputeTxTime' was not declared.
> 	Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
> 	symbol 'txqueue2outpipe' was not declared.
> 	Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
> 	symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
> 	Should it be static?
> 
> Signed-off-by: Fred Chou <fred.chou.nd@gmail.com>
> ---
>  drivers/staging/rtl8192u/r8192U_core.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Your From: line does not match your "Signed-off-by:" line, so I can't
take this :(


  reply	other threads:[~2014-12-03  0:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01  1:54 [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c Fred
2014-12-03  0:54 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-12-03  2:38 Fred Chou
2014-12-03  5:54 ` Sudip Mukherjee
2014-12-03  2:31 Fred Chou
2014-12-03  3:51 ` Greg KH
2014-11-28  8:56 Fred

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203005407.GA4433@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=fred.chou.nd@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.