From: Theodore Ts'o <tytso@mit.edu>
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: linux-ext4@vger.kernel.org, darrick.wong@oracle.com
Subject: Re: [PATCH v3 1/3] e2fsprogs/tune2fs: fix memory leak in inode_scan_and_fix()
Date: Tue, 2 Dec 2014 21:07:08 -0500 [thread overview]
Message-ID: <20141203020708.GL13618@thunk.org> (raw)
In-Reply-To: <1415956537-11212-1-git-send-email-wangxg.fnst@cn.fujitsu.com>
On Fri, Nov 14, 2014 at 05:15:35PM +0800, Xiaoguang Wang wrote:
> When we use ext2fs_open_inode_scan() to iterate inodes and finish
> jobs, we also need a ext2fs_close_inode_scan(scan) operation, but in
> inode_scan_and_fix(), we forgot to call it, fix this error.
>
> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2014-12-03 2:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 9:49 [PATCH v2 1/3] e2fsprogs/tune2fs: fix memory leak in inode_scan_and_fix() Xiaoguang Wang
2014-11-12 9:49 ` [PATCH v2 2/3] e2fsprogs/tune2fs: rewrite metadata checksums when resizing inode size Xiaoguang Wang
2014-11-12 22:39 ` Darrick J. Wong
2014-11-14 8:57 ` Xiaoguang Wang
2014-11-12 9:49 ` [PATCH v2 3/3] e2fsprogs/tune2fs: fix memory write overflow Xiaoguang Wang
2014-11-14 9:15 ` [PATCH v3 1/3] e2fsprogs/tune2fs: fix memory leak in inode_scan_and_fix() Xiaoguang Wang
2014-11-14 9:15 ` [PATCH v3 2/3] e2fsprogs/tune2fs: rewrite metadata checksums when resizing inode size Xiaoguang Wang
2014-11-14 23:10 ` Darrick J. Wong
2014-11-17 1:56 ` Xiaoguang Wang
2014-11-17 19:10 ` [PATCH] tune2fs: disable csum verification before resizing inode Darrick J. Wong
2014-12-03 3:33 ` Theodore Ts'o
2014-12-03 3:46 ` Theodore Ts'o
2014-12-03 5:39 ` Darrick J. Wong
2014-12-03 14:34 ` Theodore Ts'o
2014-12-03 3:30 ` [PATCH v3 2/3] e2fsprogs/tune2fs: rewrite metadata checksums when resizing inode size Theodore Ts'o
2014-11-14 9:15 ` [PATCH v3 3/3] e2fsprogs/tune2fs: fix memory write overflow Xiaoguang Wang
2014-11-14 18:58 ` Darrick J. Wong
2014-12-03 3:32 ` Theodore Ts'o
2014-12-03 2:07 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203020708.GL13618@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.