All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: gitster@pobox.com, git@vger.kernel.org, ronniesahlberg@gmail.com,
	mhagger@alum.mit.edu
Subject: Re: [PATCH 2/4] refs.c: rename transaction.updates to transaction.ref_updates
Date: Tue, 2 Dec 2014 18:43:01 -0800	[thread overview]
Message-ID: <20141203024301.GE6527@google.com> (raw)
In-Reply-To: <1417506402-24257-3-git-send-email-sbeller@google.com>

Stefan Beller wrote:

> The updates are only holding refs not reflogs, so express it to the reader.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  refs.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Makes sense.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

  reply	other threads:[~2014-12-03  2:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02  7:46 [PATCHv2 0/4] refs.c: use transactions for the reflog Stefan Beller
2014-12-02  7:46 ` [PATCH 1/4] refs.c: rename the transaction functions Stefan Beller
2014-12-03  2:24   ` Jonathan Nieder
2014-12-02  7:46 ` [PATCH 2/4] refs.c: rename transaction.updates to transaction.ref_updates Stefan Beller
2014-12-03  2:43   ` Jonathan Nieder [this message]
2014-12-02  7:46 ` [PATCH 3/4] refs.c: add a transaction function to append a reflog entry Stefan Beller
2014-12-03  3:15   ` Jonathan Nieder
2014-12-03 22:28     ` Stefan Beller
2014-12-03 22:52       ` Jonathan Nieder
2014-12-02  7:46 ` [PATCH 4/4] reflog.c: use a reflog transaction when writing during expire Stefan Beller
2014-12-03  3:18   ` Jonathan Nieder
2014-12-03 18:05 ` [PATCHv2 0/4] refs.c: use transactions for the reflog Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203024301.GE6527@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mhagger@alum.mit.edu \
    --cc=ronniesahlberg@gmail.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.