From: Curt Brune <curt@cumulusnetworks.com>
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] adt7475 driver: PWM invert configuration bit
Date: Wed, 03 Dec 2014 04:12:42 +0000 [thread overview]
Message-ID: <20141203041242.GD11971@cumulusnetworks.com> (raw)
Hello,
I have a system where I need to change the "PWM invert" bit (bit 4) in
the PWM configuration register (offset 0x5C). The description of this
configuration bit from the data sheet:
This bit inverts the PWM output. The default is 0, which corresponds
to a logic high output for 100% duty cycle. Setting this bit to 1
inverts the PWM output, so 100% duty cycle corresponds to a logic
low output.
I noticed the adt7475.c driver does not expose this bit in sysfs.
Before hacking away I am curious to know why this configuration bit is
not exposed already. Some reasons I could think of:
- expect the power on default to be correct
- expect some other software (boot loader or BIOS) has already set it
- just never needed it
If it was just never needed then I am proposing to add 3 read/write
files to sysfs:
pwm1_invert
pwm2_invert
pwm3_invert
The values of 0 and 1 would have the same meaning as the "PWM invert"
bit (bit 4) in the PWM configuration register (offset 0x5C). Any
other value would be treated as -EINVAL.
Cheers,
Curt
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2014-12-03 4:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 4:12 Curt Brune [this message]
2014-12-03 5:29 ` [lm-sensors] adt7475 driver: PWM invert configuration bit Guenter Roeck
2014-12-04 0:18 ` Curt Brune
2014-12-04 1:10 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203041242.GD11971@cumulusnetworks.com \
--to=curt@cumulusnetworks.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.