Re: [PATCH] Input : Initialize input_no by -1

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Tue, Dec 02, 2014 at 03:29:23PM -0800, Dmitry Torokhov wrote:
> On Tue, Dec 02, 2014 at 10:15:29PM +0530, Aniroop Mathur wrote:
> > This patch initializes input_no by -1 in order to avoid extra subtraction
> > operation performed everytime for allocation of an input device.
> > 
> > Signed-off-by: Aniroop Mathur <aniroop.mathur@gmail.com>
> 
> Applied, thank you.
> 
> By the way, we have a few more places in drivers/input that count from 0, we
> may want to change them as well.

Also, for patches of such nature (non urgent) there is no need to ping me so
often.

Thanks.

> 
> > ---
> >  drivers/input/input.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/input/input.c b/drivers/input/input.c
> > index 29ca0bb..01fe49e 100644
> > --- a/drivers/input/input.c
> > +++ b/drivers/input/input.c
> > @@ -1774,7 +1774,7 @@ EXPORT_SYMBOL_GPL(input_class);
> >   */
> >  struct input_dev *input_allocate_device(void)
> >  {
> > -	static atomic_t input_no = ATOMIC_INIT(0);
> > +	static atomic_t input_no = ATOMIC_INIT(-1);
> >  	struct input_dev *dev;
> >  
> >  	dev = kzalloc(sizeof(struct input_dev), GFP_KERNEL);
> > @@ -1789,7 +1789,7 @@ struct input_dev *input_allocate_device(void)
> >  		INIT_LIST_HEAD(&dev->node);
> >  
> >  		dev_set_name(&dev->dev, "input%ld",
> > -			     (unsigned long) atomic_inc_return(&input_no) - 1);
> > +			     (unsigned long) atomic_inc_return(&input_no));
> >  
> >  		__module_get(THIS_MODULE);
> >  	}
> > -- 
> > 1.9.1
> > 
> 
> Thanks.
> 
> -- 
> Dmitry

-- 
Dmitry