From: Darren Hart <dvhart@infradead.org>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] toshiba_acpi: Move hotkey enabling code to own function
Date: Wed, 3 Dec 2014 01:22:38 -0800 [thread overview]
Message-ID: <20141203092237.GF52608@vmdeb7> (raw)
In-Reply-To: <1417584992-2524-2-git-send-email-coproscefalo@gmail.com>
On Tue, Dec 02, 2014 at 10:36:31PM -0700, Azael Avalos wrote:
> The hotkey enabling code is being used by
> *_setup_keyboard and also by *_resume.
>
> This patch creates a new function called
> toshiba_acpi_enable_hotkeys to be used by
> these two functions to avoid duplicating
> code.
42 is a little bit narrow, even for us kernel types :-) 72 characters wide is
fine.
Patch is fine, but since I had some questions on your others, please correct in
V2.
Thanks,
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2014-12-04 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 5:36 [PATCH 0/2] toshiba_acpi: Hotkeys and event handling changes Azael Avalos
2014-12-03 5:36 ` [PATCH 1/2] toshiba_acpi: Move hotkey enabling code to own function Azael Avalos
2014-12-03 9:22 ` Darren Hart [this message]
2014-12-03 5:36 ` [PATCH 2/2] toshiba_acpi: Change notify funtion to handle more events Azael Avalos
2014-12-03 9:21 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203092237.GF52608@vmdeb7 \
--to=dvhart@infradead.org \
--cc=coproscefalo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.