From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability Date: Wed, 3 Dec 2014 11:26:36 +0100 Message-ID: <20141203102636.GA29307@aepfle.de> References: <1417533090-29651-1-git-send-email-wei.liu2@citrix.com> <20141202183755.GF32385@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20141202183755.GF32385@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Mark Pryor , Wei Liu , Ian Campbell , "Luis R. Rodriguez" , Ian Jackson , xen-devel@lists.xen.org, m.a.young@durham.ac.uk, Anthony Perard List-Id: xen-devel@lists.xenproject.org On Tue, Dec 02, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 02, 2014 at 03:11:30PM +0000, Wei Liu wrote: > > AC_CHECK_LIB fails on Debian Jessie since the ld flag it generates is > > incorrect, even in the event systemd library is available. Use > > PKG_CHECK_MODULES instead. > > > > Tested on Debian Jessie and Arch Linux. > > And Fedora and SuSE? CC-ing the other distro maintainers > for their input. I'm fine with that. But: It seems be that sd_listen_fds() is new in v209. It was backported to v208 in openSUSE 13.1. So there should be some detection if sd_listen_fds() is really available. Looks like this patch removes the check. I get this from pkg-config: root@optiplex:/work/olaf/13.1/github/olafhering/xen.git # pkg-config --cflags libsystemd-daemon ; echo $? 0 root@optiplex:/work/olaf/13.1/github/olafhering/xen.git # pkg-config --libs libsystemd-daemon ; echo $? -lsystemd-daemon 0 Olaf