From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Álvaro Neira Ayuso" <alvaroneay@gmail.com>
Cc: Eric Leblond <eric@regit.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] datatype: fix name of icmp* code
Date: Wed, 3 Dec 2014 12:54:17 +0100 [thread overview]
Message-ID: <20141203115417.GA13593@salvia> (raw)
In-Reply-To: <547EF31B.9020709@gmail.com>
On Wed, Dec 03, 2014 at 12:25:15PM +0100, Álvaro Neira Ayuso wrote:
> Hi Eric
>
> El 03/12/14 a las 00:02, Eric Leblond escribió:
> >The name of datatypes can be used in set definition so they should
> >follow the same logic (and maybe not contain space to avoid problem
> >with parsing).
> >
> >This patch adds an underscore to the name of the icmp* code
> >datatype.
> >
> >Signed-off-by: Eric Leblond <eric@regit.org>
>
> Looks good to me. Thanks, I have used a uncorrect name format :)
Applied, thanks for reviewing.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-12-03 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 23:02 [nft PATCH] datatype: fix name of icmp* code Eric Leblond
2014-12-03 11:25 ` Álvaro Neira Ayuso
2014-12-03 11:54 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203115417.GA13593@salvia \
--to=pablo@netfilter.org \
--cc=alvaroneay@gmail.com \
--cc=eric@regit.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.