From: Darren Hart <dvhart@infradead.org>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] toshiba_acpi: Change notify funtion to handle more events
Date: Wed, 3 Dec 2014 05:19:07 -0800 [thread overview]
Message-ID: <20141203131907.GF75099@vmdeb7> (raw)
In-Reply-To: <CAGdLNWFpvSLZorQ6WNpEBZ+rkxcP7CR0vxtW4ugmyxojNRWLVg@mail.gmail.com>
On Thu, Dec 04, 2014 at 08:10:49PM -0700, Azael Avalos wrote:
> Hi Darren,
>
> 2014-12-03 6:12 GMT-07:00 Darren Hart <dvhart@infradead.org>:
> > On Wed, Dec 03, 2014 at 11:42:04PM -0700, Azael Avalos wrote:
> >> @@ -1971,41 +2008,22 @@ error:
> >> static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
> >> {
> >> struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev);
> >> - u32 hci_result, value;
> >> - int retries = 3;
> >> - int scancode;
> >> -
> >> - if (event != 0x80)
> >> - return;
> >> + int ret;
> >
> > CC drivers/platform/x86/toshiba_acpi.o
> > drivers/platform/x86/toshiba_acpi.c: In function ‘toshiba_acpi_notify’:
> > drivers/platform/x86/toshiba_acpi.c:2012:6: warning: unused variable ‘ret’ [-Wunused-variable]
> > int ret;
> > ^
> >
> > Please compile check each patch.
>
> Sorry about that, was a left over from the split.
> Want me to send a V3? I can send them in few minutes.
Yes please.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2014-12-05 3:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 6:42 [PATCH v2 0/3] toshiba_acpi: Hotkeys and event handling changes Azael Avalos
2014-12-04 6:42 ` [PATCH v2 1/3] toshiba_acpi: Move hotkey enabling code to own function Azael Avalos
2014-12-04 6:42 ` [PATCH v2 2/3] toshiba_acpi: Change notify funtion to handle more events Azael Avalos
2014-12-03 13:12 ` Darren Hart
2014-12-05 3:10 ` Azael Avalos
2014-12-03 13:19 ` Darren Hart [this message]
2014-12-04 6:42 ` [PATCH v2 3/3] toshiba_acpi: Add keyboard backlight mode change event Azael Avalos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203131907.GF75099@vmdeb7 \
--to=dvhart@infradead.org \
--cc=coproscefalo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.