From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [v4] libxc: Expose the 1GB pages cpuid flag to guest Date: Wed, 3 Dec 2014 10:57:44 -0500 Message-ID: <20141203155744.GE3081@laptop.dumpdata.com> References: <1417171925-10102-1-git-send-email-liang.z.li@intel.com> <1417175443.23604.18.camel@citrix.com> <20141202210941.GA1593@laptop.dumpdata.com> <1417599529.29004.16.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1417599529.29004.16.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, Liang Li , tim@xen.org, xen-devel@lists.xen.org, JBeulich@suse.com, andrew.cooper3@citrix.com, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org On Wed, Dec 03, 2014 at 09:38:49AM +0000, Ian Campbell wrote: > On Tue, 2014-12-02 at 16:09 -0500, Konrad Rzeszutek Wilk wrote: > > On Fri, Nov 28, 2014 at 11:50:43AM +0000, Ian Campbell wrote: > > > On Fri, 2014-11-28 at 18:52 +0800, Liang Li wrote: > > > > If hardware support the 1GB pages, expose the feature to guest by > > > > default. Users don't have to use a 'cpuid= ' option in config fil > > > > e to turn it on. > > > > > > > > If guest use shadow mode, the 1GB pages feature will be hidden from > > > > guest, this is done in the function hvm_cpuid(). So the change is > > > > okay for shadow mode case. > > > > > > > > Signed-off-by: Liang Li > > > > Signed-off-by: Yang Zhang > > > > > > FTR although this is strictly speaking a toolstack patch I think the > > > main ack required should be from the x86 hypervisor guys... > > > > Jan acked it. > > For 4.5? Probably not. > > Have you release acked it? No. > > This seemed like 4.6 material to me, or at least I've not seen any > mention/argument to the contrary. Correct. 4.6 please. > > Ian. > > > > > > > > --- > > > > tools/libxc/xc_cpuid_x86.c | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_cpuid_x86.c > > > > index a18b1ff..c97f91a 100644 > > > > --- a/tools/libxc/xc_cpuid_x86.c > > > > +++ b/tools/libxc/xc_cpuid_x86.c > > > > @@ -109,6 +109,7 @@ static void amd_xc_cpuid_policy( > > > > regs[3] &= (0x0183f3ff | /* features shared with 0x00000001:EDX */ > > > > bitmaskof(X86_FEATURE_NX) | > > > > bitmaskof(X86_FEATURE_LM) | > > > > + bitmaskof(X86_FEATURE_PAGE1GB) | > > > > bitmaskof(X86_FEATURE_SYSCALL) | > > > > bitmaskof(X86_FEATURE_MP) | > > > > bitmaskof(X86_FEATURE_MMXEXT) | > > > > @@ -192,6 +193,7 @@ static void intel_xc_cpuid_policy( > > > > bitmaskof(X86_FEATURE_ABM)); > > > > regs[3] &= (bitmaskof(X86_FEATURE_NX) | > > > > bitmaskof(X86_FEATURE_LM) | > > > > + bitmaskof(X86_FEATURE_PAGE1GB) | > > > > bitmaskof(X86_FEATURE_SYSCALL) | > > > > bitmaskof(X86_FEATURE_RDTSCP)); > > > > break; > > > > @@ -386,6 +388,7 @@ static void xc_cpuid_hvm_policy( > > > > clear_bit(X86_FEATURE_LM, regs[3]); > > > > clear_bit(X86_FEATURE_NX, regs[3]); > > > > clear_bit(X86_FEATURE_PSE36, regs[3]); > > > > + clear_bit(X86_FEATURE_PAGE1GB, regs[3]); > > > > } > > > > break; > > > > > > > > > > > > > > > > _______________________________________________ > > > Xen-devel mailing list > > > Xen-devel@lists.xen.org > > > http://lists.xen.org/xen-devel > >