From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] tools/hotplug: update systemd dependency to use service instead of socket Date: Wed, 3 Dec 2014 11:54:10 -0500 Message-ID: <20141203165410.GA2819@laptop.dumpdata.com> References: <1417534763-25053-1-git-send-email-olaf@aepfle.de> <1417535095.29004.4.camel@citrix.com> <20141202184240.GI32385@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: M A Young Cc: Olaf Hering , Wei Liu , Ian Campbell , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, Dec 02, 2014 at 06:51:50PM +0000, M A Young wrote: > On Tue, 2 Dec 2014, Konrad Rzeszutek Wilk wrote: > > >On Tue, Dec 02, 2014 at 03:44:55PM +0000, Ian Campbell wrote: > >>On Tue, 2014-12-02 at 16:39 +0100, Olaf Hering wrote: > >>>Since commit 4542ae340d75bd6319e3fcd94e6c9336e210aeef ("tools/hotplug: > >>>systemd xenstored dependencies") all service files use the .socket unit > >>>as startup dependency. While this happens to work for boot it fails for > >>>shutdown because a .socket does not seem to enforce ordering. When > >>>xendomains.service runs during shutdown then systemd will stop > >>>xenstored.service at the same time. > >>> > >>>Change all "xenstored.socket" to "xenstored.service" to let systemd know > >>>that xenstored has to be shutdown after everything else. > >>> > >>>Reported-by: Mark Pryor > >>>Signed-off-by: Olaf Hering > >>>Cc: Ian Jackson > >>>Cc: Stefano Stabellini > >> > >>Acked-by: Ian Campbell > >> > >>>Cc: Wei Liu > >>>--- > >>> > >>>This should go into 4.5 to fix xendomains.service. > >> > >>CCing Konrad... > > > >CC-ing Michael. > > > >Michael, since Fedora is using systemd, did you observe this bug as well? > >(I think I did, but I might have blamed it on my wacky setup). > > I only tried the xen systemd on xen 4.5-rc2 and didn't have a lot of success > even when I reverted to Fedora's systemd for xen, so I can't really comment. > I did have issues with xen systemd which I shall report if they are still > there in -rc3. It seems that hte issue I am having is: ELinux: security_context_to_sid($XENSTORED_MOUNT_CTX) failed for (dev tmpfs, type tmpfs) er Dec 03 11:46:07 laptop.dumpdata.com systemd[1]: var-lib-xenstored.mount mount process exited, code=exited status=32 Dec 03 11:46:07 laptop.dumpdata.com systemd[1]: Failed to mount mount xenstore file system. Which looks like so: [root@laptop system]# more var-lib-xenstored.mount [Unit] Description=mount xenstore file system Requires=proc-xen.mount After=proc-xen.mount ConditionPathExists=/proc/xen/capabilities RefuseManualStop=true [Mount] Environment=XENSTORED_MOUNT_CTX=none EnvironmentFile=-/etc/sysconfig/xenstored What=xenstore Where=/var/lib/xenstored Type=tmpfs Options=mode=755,context="$XENSTORED_MOUNT_CTX" There is no /etc/sysconfig/xenstored (there is an oxenstored.conf) If I alter it: Options=mode=755 #,context="$XENSTORED_MOUNT_CTX" It starts. > > Michael Young