From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sean Cleator <seancleator@hotmail.co.uk>,
lidza.louina@gmail.com, driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h
Date: Wed, 3 Dec 2014 21:10:44 +0300 [thread overview]
Message-ID: <20141203181044.GM4994@mwanda> (raw)
In-Reply-To: <20141203173441.GA12889@kroah.com>
On Wed, Dec 03, 2014 at 09:34:41AM -0800, Greg KH wrote:
> > +#define UART_IIR_CTSRTS 0x20 /*
> > + * Received CTS/RTS change of
> > + * state
> > + */
>
> That's pretty ugly, don't you think? How about putting the comments on
> the line before the #define, instead of at the end? That would make
> things much nicer to read.
>
I was going to say the same thing but it looks worse in the mail client
because of how the tabs work out. In the code it doesn't look terrible.
#define UART_IIR_CTSRTS 0x20 /*
* Received CTS/RTS change of
* state
*/
Another idea would be to just remove a tab. It wouldn't align with the
section before but it would align with the next section down.
regards,
dan carpenter
next prev parent reply other threads:[~2014-12-03 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 17:07 [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h Sean Cleator
2014-12-03 17:34 ` Greg KH
2014-12-03 18:10 ` Dan Carpenter [this message]
2014-12-03 18:18 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203181044.GM4994@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seancleator@hotmail.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.