From: Frederic Weisbecker <fweisbec@gmail.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Richard Guy Briggs <rgb@redhat.com>,
Eric Paris <eparis@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dave Jones <davej@redhat.com>, Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH v2] context_tracking: Restore previous state in schedule_user
Date: Thu, 4 Dec 2014 01:01:38 +0100 [thread overview]
Message-ID: <20141204000137.GF31369@lerouge> (raw)
In-Reply-To: <20141203235002.GW25340@linux.vnet.ibm.com>
On Wed, Dec 03, 2014 at 03:50:02PM -0800, Paul E. McKenney wrote:
> On Wed, Dec 03, 2014 at 03:37:08PM -0800, Andy Lutomirski wrote:
> > It appears that some SCHEDULE_USER (asm for schedule_user) callers
> > in arch/x86/kernel/entry_64.S are called from RCU kernel context,
> > and schedule_user will return in RCU user context. This causes RCU
> > warnings and possible failures.
> >
> > This is intended to be a minimal fix suitable for 3.18.
> >
> > Reported-and-tested-by: Dave Jones <davej@redhat.com>
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > Cc: Frédéric Weisbecker <fweisbec@gmail.com>
> > Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
> > Signed-off-by: Andy Lutomirski <luto@amacapital.net>
>
> Looks like the RCU entry/exit stuff is properly accounted for, so:
>
> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Thanks a lot guys!
I'll take the patch. This just won't go for 3.18 I think, the issue
is there since the early days of context tracking.
prev parent reply other threads:[~2014-12-04 0:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 18:19 audit: rcu_read_lock() used illegally while idle Dave Jones
2014-12-03 19:29 ` Paul E. McKenney
2014-12-03 20:06 ` Andy Lutomirski
2014-12-03 20:19 ` Dave Jones
2014-12-03 20:38 ` Andy Lutomirski
2014-12-03 22:08 ` Frederic Weisbecker
2014-12-03 22:12 ` Andy Lutomirski
2014-12-03 23:49 ` Frederic Weisbecker
2014-12-03 23:18 ` [PATCH] context_tracking: Restore previous state in schedule_user Andy Lutomirski
2014-12-03 23:26 ` Andy Lutomirski
2014-12-03 23:31 ` Dave Jones
2014-12-03 23:58 ` Frederic Weisbecker
2014-12-04 0:04 ` Andy Lutomirski
2014-12-04 0:30 ` Dave Jones
2014-12-04 0:38 ` Andy Lutomirski
2014-12-04 1:13 ` Frederic Weisbecker
2014-12-03 23:37 ` [PATCH v2] " Andy Lutomirski
2014-12-03 23:50 ` Paul E. McKenney
2014-12-04 0:01 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204000137.GF31369@lerouge \
--to=fweisbec@gmail.com \
--cc=davej@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rgb@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.