All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>, git@vger.kernel.org
Subject: [PATCH 0/2] disabling terminal prompts
Date: Wed, 3 Dec 2014 22:42:07 -0500	[thread overview]
Message-ID: <20141204034206.GA1493@peff.net> (raw)
In-Reply-To: <20141204004231.GA200195@vauxhall.crustytoothpaste.net>

On Thu, Dec 04, 2014 at 12:42:31AM +0000, brian m. carlson wrote:

> I'll probably submit a patch to disable the terminal prompting this
> weekend.

Too late. You got me thinking about it, so I wrote the following series.

  [1/2]: credential: let helpers tell us to quit
  [2/2]: prompt: respect GIT_TERMINAL_PROMPT to disable terminal prompts

Technically the second one is redundant with the first. You could just
define a credential helper which bails before we get to the prompts. But
for simple cases, I think that:

  GIT_TERMINAL_PROMPT=0 git ...

is a lot more intuitive than:

  git -c credential.helper='!f() { echo quit=1; }; f' ...

and is also easier to set at the top of a non-interactive script. The
first is not redundant with the second, because it is a lot more
flexible. E.g., you can abort only after seeing that we match a specific
URL, or after running any arbitrary code you like (e.g., checking out
some characteristics of the tty and deciding it is not a good idea to
access it).

There is one thing this _doesn't_ handle, which is that of preventing
existing configured credential-helpers from running (even a helper you
define with "git -c" runs after the others). But I think that is a
separate issue.

-Peff

  reply	other threads:[~2014-12-04  3:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  0:03 Disabling credential helper? brian m. carlson
2014-12-03  0:59 ` Jonathan Nieder
2014-12-03  1:21   ` Jeff King
2014-12-03  1:29     ` Jonathan Nieder
2014-12-03  1:36       ` Jeff King
2014-12-04  1:33         ` Jeff King
2014-12-04  6:07           ` Junio C Hamano
2014-12-03 17:14     ` Junio C Hamano
2014-12-04  0:42     ` brian m. carlson
2014-12-04  3:42       ` Jeff King [this message]
2014-12-04  3:46         ` [PATCH 1/2] credential: let helpers tell us to quit Jeff King
2014-12-04  3:52         ` [PATCH 2/2] prompt: respect GIT_TERMINAL_PROMPT to disable terminal prompts Jeff King
2014-12-04 18:24           ` Junio C Hamano
2014-12-04 21:01             ` Jeff King
2014-12-04 21:33               ` Junio C Hamano
2014-12-05  9:10                 ` Jeff King
2014-12-05 17:37                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141204034206.GA1493@peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.