From: Christoph Hellwig <hch@infradead.org>
To: Laurence Oberman <loberman@redhat.com>
Cc: linux-scsi@vger.kernel.org, Chad Dupuis <cdupuis@redhat.com>
Subject: Re: [PATCH qla2xxx] Race in handling rport deletion in Qlogic driver during recovery causes panic
Date: Thu, 4 Dec 2014 00:44:37 -0800 [thread overview]
Message-ID: <20141204084437.GA12187@infradead.org> (raw)
In-Reply-To: <827904999.3215615.1416925002571.JavaMail.zimbra@redhat.com>
On Tue, Nov 25, 2014 at 09:16:42AM -0500, Laurence Oberman wrote:
> When we have an rport disconnect we race during rport deletion and re-connection resulting in a panic.
> When we do this, we call fc_remote_port_del() just before we do the calls to re-establish the session with
> the FC transport with fc_remote_port_add() and then fc_remote_port_rolechg().
>
> If we remove the call to fc_remote_port_del() before re-establishing the connection this prevents the race.
> This patch has resolved this for multiple customers via test kernels.
>
> Suggested by Chad Dupuis, implemented and tested by Laurence Oberman.
Chad, can you review this one? Or do you plan to send it to me with the
next qla2xxx update? Note that the 3.19 merge window is about to end.
next prev parent reply other threads:[~2014-12-04 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <66112100.3203938.1416924145624.JavaMail.zimbra@redhat.com>
2014-11-25 14:16 ` [PATCH qla2xxx] Race in handling rport deletion in Qlogic driver during recovery causes panic Laurence Oberman
2014-12-04 8:44 ` Christoph Hellwig [this message]
2014-12-04 20:18 ` Chad Dupuis
2014-12-15 13:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204084437.GA12187@infradead.org \
--to=hch@infradead.org \
--cc=cdupuis@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.