Re: [patch] dell-laptop: fix kbd_timeout handling

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 1191 bytes --]

On Wednesday 03 December 2014 08:33:25 Darren Hart wrote:
> On Wed, Dec 03, 2014 at 01:01:59PM +0300, Dan Carpenter wrote:
> > The original code had a static checker warning:
> > 	drivers/platform/x86/dell-laptop.c:1389
> > 	kbd_led_timeout_store() warn: this array is probably
> > 	non-NULL. 'quirks->kbd_timeouts'
> > 
> > This warning does indicate a bug.  I have added a
> > .needs_kbd_timeouts flag which is true if the
> > .kbd_timeouts[] array has been declared. Otherwise, in the
> > original code the quirk_dell_vostro_v130 struct didn't
> > 
> > have .kbd_timeouts[] declared so the loop:
> > 	for (i = 0; quirks->kbd_timeouts[i] != -1; i++) {
> > 
> > Would have read beyond the end of the struct with
> > unpredictable results.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Thanks Dan,
> 
> Pali, any objections?
> 
> Dan, any objection to Pali rolling this into another revision?
> No point in introducing the bug to next and mainline.
> 
> Thanks,

No problem from my side. This quirks code was done by Gabriele to 
fix BIOS problems on some laptops.

Gabriele, any objections?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]