From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask()
Date: Thu, 4 Dec 2014 14:37:09 +0000 [thread overview]
Message-ID: <20141204143708.GM29748@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1417699659-14284-3-git-send-email-jack@suse.cz>
On Thu, Dec 04, 2014 at 02:27:36PM +0100, Jan Kara wrote:
> WARN_ON in inode_set_mask() warns if we don't clear all bits we are
> setting instead of reverse - warning when caller requests setting and
> clearing of the same bit.
WTF? 'mask' is "all bits we are asked to modify", 'flags' - "the values to
put into those bits". Have you even looked at the callers, let alone
tested it?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-12-04 14:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 13:27 [PATCH 0/5] fs: Fixes for removing xid bits and security labels Jan Kara
2014-12-04 13:27 ` Jan Kara
2014-12-04 13:27 ` [PATCH 1/5] fs: Rename file_remove_suid() to file_remove_privs() Jan Kara
2014-12-04 13:27 ` [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask() Jan Kara
2014-12-04 13:27 ` Jan Kara
2014-12-04 14:37 ` Al Viro [this message]
2014-12-04 18:34 ` Jan Kara
2014-12-04 18:34 ` Jan Kara
2014-12-04 13:27 ` [PATCH 3/5] fs: Provide function telling whether file_remove_privs() will do anything Jan Kara
2014-12-04 13:27 ` Jan Kara
2014-12-04 13:27 ` [PATCH 4/5] fs: Remove security attributes on truncate Jan Kara
2014-12-04 13:27 ` Jan Kara
2014-12-05 16:06 ` Casey Schaufler
2014-12-09 18:27 ` Jan Kara
2014-12-09 18:27 ` Jan Kara
2014-12-09 18:59 ` Casey Schaufler
2014-12-10 11:11 ` Jan Kara
2014-12-10 11:11 ` Jan Kara
2014-12-16 9:46 ` Jan Kara
2014-12-04 13:27 ` [PATCH 5/5] xfs: Correctly lock inode when removing suid and security marks Jan Kara
2014-12-04 13:27 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204143708.GM29748@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.