From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm: Fix memory leak at error path of drm_read() Date: Thu, 4 Dec 2014 18:25:08 +0100 Message-ID: <20141204172508.GG20350@phenom.ffwll.local> References: <1417690603-1595-1-git-send-email-tiwai@suse.de> <20141204115114.GB13586@nuc-i3427.alporthouse.com> <20141204122839.GE20350@phenom.ffwll.local> <20141204163115.GF13586@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 26D9E6E318 for ; Thu, 4 Dec 2014 09:24:39 -0800 (PST) Received: by mail-wi0-f179.google.com with SMTP id ex7so28740443wid.0 for ; Thu, 04 Dec 2014 09:24:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <20141204163115.GF13586@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , Daniel Vetter , Takashi Iwai , dri-devel@lists.freedesktop.org, Maarten Lankhorst List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBEZWMgMDQsIDIwMTQgYXQgMDQ6MzE6MTVQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFRodSwgRGVjIDA0LCAyMDE0IGF0IDAxOjI4OjM5UE0gKzAxMDAsIERhbmllbCBW ZXR0ZXIgd3JvdGU6Cj4gPiBPbiBUaHUsIERlYyAwNCwgMjAxNCBhdCAxMTo1MToxNEFNICswMDAw LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiA+IE9uIFRodSwgRGVjIDA0LCAyMDE0IGF0IDExOjU2 OjQyQU0gKzAxMDAsIFRha2FzaGkgSXdhaSB3cm90ZToKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBU YWthc2hpIEl3YWkgPHRpd2FpQHN1c2UuZGU+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMv Z3B1L2RybS9kcm1fZm9wcy5jIHwgMSArCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy dGlvbigrKQo+ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2ZvcHMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm9wcy5jCj4gPiA+ID4gaW5kZXggZWQ3YmM2 OGY3ZTg3Li5hODJkYzI4ZDU0ZjMgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2RybV9mb3BzLmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZvcHMuYwo+ID4g PiA+IEBAIC01MjUsNiArNTI1LDcgQEAgc3NpemVfdCBkcm1fcmVhZChzdHJ1Y3QgZmlsZSAqZmls cCwgY2hhciBfX3VzZXIgKmJ1ZmZlciwKPiA+ID4gPiAgCQlpZiAoY29weV90b191c2VyKGJ1ZmZl ciArIHRvdGFsLAo+ID4gPiA+ICAJCQkJIGUtPmV2ZW50LCBlLT5ldmVudC0+bGVuZ3RoKSkgewo+ ID4gPiA+ICAJCQl0b3RhbCA9IC1FRkFVTFQ7Cj4gPiA+ID4gKwkJCWUtPmRlc3Ryb3koZSk7Cj4g PiA+IAo+ID4gPiBXZSBzaG91bGRuJ3QganVzdCBiZSB0aHJvd2luZyBhd2F5IHRoZSBldmVudCBo ZXJlLCBidXQgcHV0IHRoZSBldmVudAo+ID4gPiBiYWNrIGF0IHRoZSBmcm9udCBvZiB0aGUgcXVl dWUuIFBvc2VzIGFuIGludGVyZXN0aW5nIHJhY2UgaXNzdWUuIFNlZW1zCj4gPiA+IGxpa2Ugd2Ug d2FudCB0byBob2xkIHRoZSBzcGlubG9jayB1bnRpbCB0aGUgY29weSBpcyBjb21wbGV0ZSBzbyB0 aGF0IHdlCj4gPiA+IGNhbiBmaXggdXAgdGhlIGZhaWx1cmUgY29ycmVjdGx5Lgo+ID4gCj4gPiBJ J3ZlIHJlYWQgdGhlIG1hbnBhZ2UgZm9yIHJlYWQgYW5kIGl0IGV4cGxpY2l0bHkgc3RhdGVzIHRo YXQgd2hlbiB5b3UgZ2V0Cj4gPiBhbiBlcnJvciBpdCdzIHVuZGVmaW5lZCB3aGF0IGhhcHBlbnMg dG8gdGhlIHJlYWQgcG9zaXRpb24uIFNpbmNlIC1FRkFVTFQKPiA+IGlzIHJlYWxseSBqdXN0IGEg dXNlcnNwYWNlIGJ1ZyBJIHRoaW5rIHdlIGNhbiBoYXBwaWx5IGRyb3AgdGhlIGV2ZW50IG9uCj4g PiB0aGUgZmxvb3IsIG5vIHJlYXNvbiB0byBiZW5kIG92ZXIgaW4gdGhlIGtlcm5lbC4KPiAKPiBI bW0uIEFjdHVhbGx5IHRoZSBjb2RlIGlzIGJ1Z2d5IGlzIHRoZSBwcm92aWRlZCBidWZmZXIgaXMg dG9vIHNob3J0IGZvcgo+IHRoZSBmaXJzdCBldmVudCBpbiBPX05PTkJMT0NLIG1vZGUuCgpXZWxs IHdlIGVzc2VudGlhbGx5IHNlbmQgb3V0IGRhdGFncmFtcyBpbnN0ZWFkIG9mIGEgYnl0ZXN0cmVh bS4gSWYgd2UgbG9vawphdCByZWN2bXNnIGFuZCBmcmllbmRzIHRoZW4gZGlzY2FyZGluZyB0aGUg YWRkaXRpb25hbCBieXRlcyBpcyBzb21ldGhpbmcKdGhhdCdzIGFscmVhZHkgYmVpbmcgZG9uZS4g U28gSSdtIG5vdCB0ZXJyaWJseSBjb25jZXJuZWQgYWJvdXQgdGhhdAplaXRoZXIuIEl0J3MgYSBi aXQgbm9uLXByZXR0eSB0aGF0IHdlIHVzZSByZWFkIGFuZCBub3QgcmVpY3Ztc2cgYnV0IHNpbmNl CndlIHVzZSByZWFkIGFscmVhZHkgbm90IHNvbWV0aGluZyB3ZSBjYW4gZXZlciBmaXguCi1EYW5p ZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9u Cis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK