From: Luis Henriques <henrix@camandro.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Wong <normalperson@yhbt.net>, git@vger.kernel.org
Subject: Re: [RFC][PATCH] send-email: add --[no-]xmailer option
Date: Thu, 4 Dec 2014 19:22:45 +0000 [thread overview]
Message-ID: <20141204192245.GA3386@charon.olymp> (raw)
In-Reply-To: <xmqqk328k6ya.fsf@gitster.dls.corp.google.com>
On Wed, Dec 03, 2014 at 08:56:45AM -0800, Junio C Hamano wrote:
> Eric Wong <normalperson@yhbt.net> writes:
>
> > Luis Henriques <henrix@camandro.org> wrote:
> >> On Mon, Mar 24, 2014 at 09:38:27PM +0000, Luis Henriques wrote:
> >> > Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:'
> >> > header to the email being sent.
> >> >
> >>
> >> Ping
> >>
> >> It's been a while since I sent this patch. Is there any interest in
> >> having this switch in git-send-email?
> >
> > I wasn't paying attention when the original was sent, but this
> > looks good to me.
> >
> > Acked-by: Eric Wong <normalperson@yhbt.net>
> >
> >> I honestly don't like disclosing too much information about my system,
> >> in this case which MUA I'm using and its version.
> >
> > Right on. I would even favor this being the default.
> >
> > Auto-generated Message-Id headers also shows the use of git-send-email;
> > perhaps there can be a way to configure that, too. However,
> > git-send-email respects manually-added Message-Id headers in the
> > original patch, so it's less of a problem, I suppose.
>
> I actually do not think this is a good idea from debuggability.
Do you think this could be merged with yet another switch? I can't
think of a name for the switch, something like... "--hide-msgid"?
Another option would be to re-work the --no-xmailer switch to change
it into a "--hide-id" (or something), where both the "X-Mailer:"
header would be dropped and the Message-id would be obfuscated.
Cheers,
--
Luís
next prev parent reply other threads:[~2014-12-04 19:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 21:38 [RFC][PATCH] send-email: add --[no-]xmailer option Luis Henriques
2014-12-02 19:32 ` Luis Henriques
2014-12-03 2:34 ` Eric Wong
2014-12-03 3:22 ` Kyle J. McKay
2014-12-03 10:13 ` Luis Henriques
2014-12-03 16:56 ` Junio C Hamano
2014-12-04 19:22 ` Luis Henriques [this message]
2014-12-04 19:33 ` Junio C Hamano
2014-12-04 19:44 ` Luis Henriques
2014-12-03 17:08 ` Junio C Hamano
2014-12-03 17:23 ` Junio C Hamano
2014-12-03 17:39 ` Junio C Hamano
2014-12-03 18:02 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204192245.GA3386@charon.olymp \
--to=henrix@camandro.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.