All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (lm75) Strengthen detect function
Date: Thu, 04 Dec 2014 21:08:23 +0000	[thread overview]
Message-ID: <20141204210823.GA9986@roeck-us.net> (raw)
In-Reply-To: <1417716250-14598-1-git-send-email-linux@roeck-us.net>

On Thu, Dec 04, 2014 at 12:16:29PM -0800, Robert Coulson wrote:
> Hello Guenter,
> 
> does it also make sense to include a check for the conf != 0 here (it
> should be set to 0 for POR from the datasheet)? Other than this
> quesiton/comment, the code looks fine to me.
> 
Hi Rob,

the configuration register could be set to a non-zero value,
for example by the BIOS or rommon. Sure, that is in theory possible
for the hysteresis and limit registers as well, but that would be
both unlikely and unreasonable.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2014-12-04 21:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 18:04 [lm-sensors] [PATCH] hwmon: (lm75) Strengthen detect function Guenter Roeck
2014-12-04 20:16 ` Robert Coulson
2014-12-04 21:08 ` Guenter Roeck [this message]
2014-12-04 23:49 ` Robert Coulson
2014-12-05 11:57 ` Jean Delvare
2014-12-05 14:14 ` Guenter Roeck
2014-12-05 15:15 ` Jean Delvare
2014-12-05 16:47 ` Guenter Roeck
2014-12-06 12:12 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141204210823.GA9986@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.