From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] tools/hotplug: update systemd dependency to
 use service instead of socket
Date: Fri, 5 Dec 2014 09:03:08 +0100
Message-ID: <20141205080307.GA31016@aepfle.de>
References: <1417534763-25053-1-git-send-email-olaf@aepfle.de>
	<1417535095.29004.4.camel@citrix.com>
	<20141202184240.GI32385@laptop.dumpdata.com>
	<alpine.DEB.2.00.1412021846570.2643@procyon.dur.ac.uk>
	<20141203165410.GA2819@laptop.dumpdata.com>
	<alpine.DEB.2.00.1412032105270.16535@procyon.dur.ac.uk>
	<20141204074756.GA4505@aepfle.de>
	<20141205021508.GB19424@andromeda.dapyr.net>
	<20141205074733.GA29524@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20141205074733.GA29524@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, M A Young <m.a.young@durham.ac.uk>
List-Id: xen-devel@lists.xenproject.org

On Fri, Dec 05, Olaf Hering wrote:

> On Thu, Dec 04, Konrad Rzeszutek Wilk wrote:
> 
> > On Thu, Dec 04, 2014 at 08:47:56AM +0100, Olaf Hering wrote:
> > > Is that something the sysadmin has to adjust, or should the xen source
> > > provide proper values?
> > It would be rather cumbersome if the sysadmin had to adjust it. The goal
> > here would be that distros could use it and package it neatly so that it
> > works out of the box.
> > 
> > What are the proper values in SuSE?
> 
> I have no idea, we dont run with selinux. At least not per default.
> So what is supposed to be there, why does it happen to work for me?
> 
> And if there are changes required to the config file, they should be
> passed in via configure instead of doing a patch.

So looking again at
tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in it seems that it
happens to work for me because XENSTORED_MOUNT_CTX is set within that
file. So if something happens to need a different value for
XENSTORED_MOUNT_CTX it has to be provided in the to-be-created config
file: EnvironmentFile=-@CONFIG_DIR@/@CONFIG_LEAF_DIR@/xenstored
This config file is not part of xen. 

Does the current state of xen-4.5 (like "make rpmball") not work out of
the box on Fedora or anything that uses selinux? If thats the case it
should probably be covered in the INSTALL file.

Olaf