Re: [PATCHv5 2/3] kernel: add support for live patching

[Josh Poimboeuf <jpoimboe@redhat.com>]

On Fri, Dec 05, 2014 at 06:55:04PM +0100, Jiri Slaby wrote:
> On 12/04/2014, 04:53 PM, Seth Jennings wrote:
> ...
> > --- /dev/null
> > +++ b/kernel/livepatch/core.c
> > @@ -0,0 +1,902 @@
> ...
> > +static struct kobj_type klp_ktype_patch = {
> > +	.sysfs_ops = &kobj_sysfs_ops,
> > +	.default_attrs = klp_patch_attrs
> > +};
> 
> Hi, I seem to have only a single comment here. If I am looking
> correctly, the last put on this kobject will cause kobject_cleanup to
> generate a warning:
>    "kobject: '%s' (%p): does not have a release() "
>    "function, it is broken and must be fixed.\n",
> 
> There should be some .release. IMO, this is a place where we will
> release the module with the patch. So the .release hook should contain
> something like a commented out module_put() with a pointer to
> klp_register_patch. (Or be empty at worst.)

Ok, thanks.

BTW, Seth will be out for at least the next week.  I'll take over the
patch set until he returns.

-- 
Josh