From: "Theodore Ts'o" <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [Bisected] linux-next 20141205 fails to mount ext4 fs on arm64 with CONFIG_ARM64_64K_PAGES=y
Date: Fri, 5 Dec 2014 15:58:00 -0500 [thread overview]
Message-ID: <20141205205800.GA10309@thunk.org> (raw)
In-Reply-To: <87oari6i77.fsf@openvz.org>
On Fri, Dec 05, 2014 at 10:54:20PM +0400, Dmitry Monakhov wrote:
> Liviu Dudau <Liviu.Dudau@arm.com> writes:
>
> Yes. This is my crap.
> - sbi->s_group_desc[group_desc]
> + gd_bh = *rcu_dereference(sbi->s_group_desc) + group_desc;
>
> Ted I have to admit that I'm an idiot.
> I already have fix where I've fixed the typo and complain from sparse
> which was reported by kbuild01. In order to prevent similar shame in future I've wrote several
> tests for resize2fs and unfortunately they are failed even w/o my
> patches. It is appeared that resize2fs is broken for big disks.
> So feel free to drop the patch, and give me some tome to investigate the
> issues. I'll back with the patch-set in 24hrs.
I had fixed the typo locally, but I'll drop this for now pending your
further investigations. BTW, I think the reason why we didn't notice
is because for smaller disks, it just worked out that
*rcu_dereference(sbi->s_group_desc) + group_desc ==
*(rcu_dereference(sbi->s_group_desc) + group_desc)
by pure luck based on how the allocator works, since all of the group
descriptor bh's get allocated back to back.
Let me know about your resize2fs failures on big disks; I had found
fixed a large number of problems with online and offline resizes with
huge disks, so I had done quite a bit of testing in that area. I
thought I had caught all of them, but if there are some additional
e2fsprogs or online resize bugs in the kernel bugs, I'd really like to
know. Thanks!!
- Ted
prev parent reply other threads:[~2014-12-05 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 18:30 [Bisected] linux-next 20141205 fails to mount ext4 fs on arm64 with CONFIG_ARM64_64K_PAGES=y Liviu Dudau
2014-12-05 18:54 ` Dmitry Monakhov
2014-12-05 20:58 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141205205800.GA10309@thunk.org \
--to=tytso@mit.edu \
--cc=Liviu.Dudau@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dmonakhov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.