From: Mike Snitzer <snitzer@redhat.com>
To: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
dm-devel@redhat.com
Subject: Re: [PATCHv2 0/4] blk-mq support for dm multipath
Date: Fri, 5 Dec 2014 19:35:18 -0500 [thread overview]
Message-ID: <20141206003518.GA1733@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1412052329050.4225@localhost.lm.intel.com>
On Fri, Dec 05 2014 at 6:33pm -0500,
Keith Busch <keith.busch@intel.com> wrote:
> On Fri, 5 Dec 2014, Mike Snitzer wrote:
> >Hi Keith,
> >
> >I've found a few issues with your v2. I've been working through the
> >code and fixing things as I see them. Please see this branch:
> >https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-for-3.19-blk-mq
> >
> >My changes build on your v2 baseline.
> >
> >How much testing have you done? It could be that my changes screwed
> >something up but... I just tried simply creating a normal request-based
> >DM multipath device (using non blk-mq devices) and hit this crash:
>
> Thanks, Mike. I'll take a look at your fixes next week.
>
> I only tested on nvme blk-mq. I don't have any SCSI devices to try,
> but I _really_ need to get one if I'm serious about making this work,
> so I'll find something next week as well.
I'll continue review to see if I can sort out why we're getting this crash.
FYI, you don't _need_ real SCSI devices to test dm-multipath. Easy
enough to just use scsi_debug so long as you have free memory:
modprobe scsi_debug dev_size_mb=100 num_tgts=1 vpd_use_hostno=0 add_host=4
add_host makes multiple paths
vpd_use_hostno=0 makes sure that all paths will have the same wwid
next prev parent reply other threads:[~2014-12-06 0:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 23:46 [PATCHv2 0/4] blk-mq support for dm multipath Keith Busch
2014-10-17 23:46 ` [PATCHv2 1/4] dm: prep initialized requests Keith Busch
2014-10-17 23:46 ` [PATCHv2 2/4] dm: Submit stacked requests in irq enabled context Keith Busch
2014-10-17 23:46 ` [PATCHv2 3/4] dm: Move request allocation to dm_target type Keith Busch
2014-10-17 23:46 ` [PATCHv2 4/4] block: blk-mq support for cloned requests Keith Busch
2014-10-28 18:13 ` [PATCHv2 0/4] blk-mq support for dm multipath Keith Busch
2014-10-28 18:26 ` Mike Snitzer
2014-12-05 23:25 ` Mike Snitzer
2014-12-05 23:33 ` Keith Busch
2014-12-06 0:35 ` Mike Snitzer [this message]
2014-12-06 5:53 ` Mike Snitzer
2014-12-06 6:09 ` Mike Snitzer
2014-12-13 2:08 ` Mike Snitzer
2014-10-28 18:48 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141206003518.GA1733@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=j-nomura@ce.jp.nec.com \
--cc=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.