From: Alfred Perlstein <alfred@freebsd.org>
To: git@vger.kernel.org
Cc: Eric Wong <normalperson@yhbt.net>,
Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
"Michael G. Schwern" <schwern@pobox.com>
Subject: [PATCH] git-svn: propset support v3
Date: Sun, 7 Dec 2014 02:46:28 -0800 [thread overview]
Message-ID: <20141207104628.GA54199@elvis.mu.org> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 1536 bytes --]
Added:
Eric Sunshine's:
- suggestion to include the comment about propset only
working on files with content changes.
Eric Wong's:
- use && to chain commands throughout tests
- use svn_cmd wrapper throughout tests
- show $! in die messages
- favor $(...) over `...` in tests
- make new_props an array simplify building the final list
- wrap long comments (help output still needs fixing)
- remove unnecessary FIXME comment
- commit message improvements.
Torsten Bögershausen:
- Fixes for test cases.
Finally, I have refactored the test cases to reduce duplicate code
such that further fixes and improvements can be done in one place.
JFYI, branches are here:
1st review changes:
https://github.com/splbio/git/compare/master-git-svn-propset-upstream?expand=1
Squashed into:
https://github.com/splbio/git/compare/master-git-svn-propset-upstream-one-diff?expand=1
Current review in different commits:
https://github.com/splbio/git/compare/master-git-svn-propset-upstream2?expand=1
Squashed into:
https://github.com/splbio/git/compare/master-git-svn-propset-upstream-one-diff2?expand=1
Thank you very much.
Alfred Perlstein (1):
git-svn: Support for git-svn propset
git-svn.perl | 49 ++++++++++++++++++++++-
perl/Git/SVN/Editor.pm | 42 ++++++++++++++++++++
t/t9148-git-svn-propset.sh | 97 ++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 187 insertions(+), 1 deletion(-)
create mode 100755 t/t9148-git-svn-propset.sh
--
2.1.2
reply other threads:[~2014-12-07 10:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141207104628.GA54199@elvis.mu.org \
--to=alfred@freebsd.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
--cc=schwern@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.