From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] ARM: dts: sun9i: Add pinmux settings for mmc2
Date: Sun, 7 Dec 2014 18:46:16 +0100 [thread overview]
Message-ID: <20141207174616.GN12434@lukather> (raw)
In-Reply-To: <CAGb2v64X8AvnqMFxxeHLa28G_7sF9vYjqU_D7R_=L4NJ+=ae7Q@mail.gmail.com>
On Sun, Dec 07, 2014 at 11:11:06PM +0800, Chen-Yu Tsai wrote:
> On Sun, Dec 7, 2014 at 11:03 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Wed, Dec 03, 2014 at 02:36:04PM +0800, Chen-Yu Tsai wrote:
> >> mmc2 is available on port C. Add a pinmux setting for usual 4 bit
> >> wide bus, as well as one with the 4 extra pins for 8 bit wide bus.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> Signed-off-by: Andreas F?rber <afaerber@suse.de>
> >> ---
> >> arch/arm/boot/dts/sun9i-a80.dtsi | 15 +++++++++++++++
> >> 1 file changed, 15 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> >> index f5b5645..fc866d8 100644
> >> --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> >> +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> >> @@ -466,6 +466,21 @@
> >> allwinner,pull = <0>;
> >> };
> >>
> >> + mmc2_pins: mmc2 {
> >> + allwinner,pins = "PC6","PC7","PC8","PC9",
> >> + "PC10","PC11";
> >> + allwinner,function = "mmc2";
> >> + allwinner,drive = <2>;
> >> + allwinner,pull = <1>;
> >> + };
> >> +
> >> + mmc2_8bit_pins: mmc2_8bit {
> >> + allwinner,pins = "PC12","PC13","PC14","PC15";
> >> + allwinner,function = "mmc2";
> >> + allwinner,drive = <2>;
> >> + allwinner,pull = <1>;
> >> + };
> >> +
> >
> > Hmmm, how is that 8 bits? There's only 4 pins here.
>
> The 8bit setting only includes the upper 4 bits.
> Using both settings together you get an 8 bit bus,
> along with CMD and CLK pins, for a total of 10 pins.
>
> Or is this the wrong way?
The way it's usually done is that you have two standalone nodes. Just
like what's done for the UARTs for example.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141207/f30b618c/attachment-0001.sig>
next prev parent reply other threads:[~2014-12-07 17:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 6:35 [PATCH 00/10] ARM: sun9i: Enable MMC support on Allwinner A80 Chen-Yu Tsai
2014-12-03 6:35 ` [PATCH 01/10] clk: sunxi: Add module 0 (storage) style clock support for A80 Chen-Yu Tsai
2014-12-06 17:13 ` Maxime Ripard
2014-12-07 1:13 ` [linux-sunxi] " Chen-Yu Tsai
2014-12-07 15:16 ` Maxime Ripard
2014-12-03 6:35 ` [PATCH 02/10] ARM: dts: sun9i: Add mmc module clock nodes " Chen-Yu Tsai
2014-12-06 17:24 ` Maxime Ripard
2014-12-07 1:11 ` Chen-Yu Tsai
2014-12-07 15:14 ` Maxime Ripard
2014-12-03 6:35 ` [PATCH 03/10] clk: sunxi: Add driver for A80 MMC config clocks/resets Chen-Yu Tsai
2014-12-06 18:01 ` Maxime Ripard
2014-12-07 1:30 ` Chen-Yu Tsai
2014-12-07 15:20 ` Maxime Ripard
2014-12-03 6:35 ` [PATCH 04/10] ARM: dts: sun9i: Add clock-indices property for bus gate clocks Chen-Yu Tsai
2014-12-03 6:36 ` [PATCH 05/10] ARM: dts: sun9i: Add mmc config clock nodes Chen-Yu Tsai
2014-12-07 15:00 ` Maxime Ripard
2014-12-07 16:00 ` Chen-Yu Tsai
2014-12-07 17:45 ` Maxime Ripard
2014-12-03 6:36 ` [PATCH 06/10] ARM: dts: sun9i: Add mmc controller nodes to the A80 dtsi Chen-Yu Tsai
2014-12-03 6:36 ` [PATCH 07/10] ARM: dts: sun9i: Add pinmux setting for mmc0 Chen-Yu Tsai
2014-12-07 15:01 ` Maxime Ripard
2014-12-03 6:36 ` [PATCH 08/10] ARM: dts: sun9i: Enable mmc0 on A80 Optimus Board Chen-Yu Tsai
2014-12-07 15:02 ` Maxime Ripard
2014-12-07 15:18 ` Chen-Yu Tsai
2014-12-07 15:35 ` Maxime Ripard
2014-12-03 6:36 ` [PATCH 09/10] ARM: dts: sun9i: Add pinmux settings for mmc2 Chen-Yu Tsai
2014-12-07 15:03 ` Maxime Ripard
2014-12-07 15:11 ` Chen-Yu Tsai
2014-12-07 17:46 ` Maxime Ripard [this message]
2014-12-03 6:36 ` [PATCH 10/10] ARM: dts: sun9i: Enable mmc2 on A80 Optimus Board Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141207174616.GN12434@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.