From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XxfbH-0007ag-Kv for mharc-grub-devel@gnu.org; Sun, 07 Dec 2014 12:26:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxfb9-0007aE-4s for grub-devel@gnu.org; Sun, 07 Dec 2014 12:26:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xxfb2-0005ga-AR for grub-devel@gnu.org; Sun, 07 Dec 2014 12:26:19 -0500 Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:56697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxfb2-0005gW-0t for grub-devel@gnu.org; Sun, 07 Dec 2014 12:26:12 -0500 Received: by mail-la0-f43.google.com with SMTP id s18so2427660lam.30 for ; Sun, 07 Dec 2014 09:26:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type; bh=glj46k3nlAMX6HcgVaZ6J3lKpwNUZ1mYvJkUwi6SYP8=; b=gVfMjMVHNPlTwityJQUs2/f/14ElxdUATppWx6JPe38eFILH8lhl3TYkCiF33DhWf7 SF+UaPpEhlBLKti+QaGCwiAwmJ4vOCJox/3frN1WjY+9kchJN2AU3nJloPZvMY5ZAJ2U u/doVgq3l5EzoWh67vM0FxUdd5MYtiCIzu/MC2A0LnFLSM6u35b29UJyOdeNKBC0IjMz Hjuy2H2Dmdh7hUlcwS3bQdl5wmkMVo1ZCg0ytE7vYBELGzk0QwA7nJH48gQMnTmO9qEW og1buTsPDOcrDQyaMktbZjMPhUEgji/+KZ/JcnRStO9mRmn+rc9YNO9ququuB6X9ZRYr tP/w== X-Received: by 10.152.19.71 with SMTP id c7mr12511696lae.79.1417973171128; Sun, 07 Dec 2014 09:26:11 -0800 (PST) Received: from opensuse.site (ppp91-76-15-25.pppoe.mtu-net.ru. [91.76.15.25]) by mx.google.com with ESMTPSA id kf6sm10107814lbc.44.2014.12.07.09.26.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Dec 2014 09:26:10 -0800 (PST) Date: Sun, 7 Dec 2014 20:26:08 +0300 From: Andrei Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] grub-install: Include all decompressor modules in pvxen core image. Message-ID: <20141207202608.0add92f0@opensuse.site> In-Reply-To: <54848BF7.5030907@gmail.com> References: <1417163614-22703-1-git-send-email-ijc@hellion.org.uk> <20141128200952.31d2c6be@opensuse.site> <1417195555.23604.69.camel@hellion.org.uk> <20141130143101.0bb4298e@opensuse.site> <1417348279.2372.20.camel@hellion.org.uk> <1417354463.2372.27.camel@hellion.org.uk> <54848BF7.5030907@gmail.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/yvB88v.Pv+2tqOy2lRpgmZU"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22b X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Dec 2014 17:26:26 -0000 --Sig_/yvB88v.Pv+2tqOy2lRpgmZU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sun, 07 Dec 2014 18:18:47 +0100 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 30.11.2014 14:34, Ian Campbell wrote: > > On Sun, 2014-11-30 at 11:51 +0000, Ian Campbell wrote: > >> On Sun, 2014-11-30 at 14:31 +0300, Andrei Borzenkov wrote: > >>> if [ x$grub_platform =3D xxen ]; then > >>> insmod xzio > >>> fi > >> > >> I think that could work. > >=20 > > Indeed it does, so how about this instead of the patch at the start of > > the thread? > >=20 > This should probably have been autoloaded. File filters are not autoloaded and I do not see how it can really be done. OTOH unconditionally loading them may have unwanted side effect where we assumed files were not decompressed. In this specific case extending grub-file to detect compression type used by kernel is probably OK. > Can you send me privately a > kernel you use, so I can reproduce your tests? > >>From f4199776eca80dfad4e9378a01ddb5866face3d7 Mon Sep 17 00:00:00 2001 > > From: Ian Campbell > > Date: Sun, 30 Nov 2014 12:12:52 +0000 > > Subject: [PATCH] Arrange to insmod xzio when booting a kernel as a Xen = guest > >=20 > > This is needed in case the Linux kernel is compiled with CONFIG_KERNEL_= XZ > > rather than CONFIG_KERNEL_GZ (gzio is already loaded by grub.cfg). > >=20 > > Signed-off-by: Ian Campbell > >=20 > > Patch-Name: insmod-xzio-on-xen.patch > > --- > > util/grub.d/10_linux.in | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in > > index 79fa03a..86e35f2 100644 > > --- a/util/grub.d/10_linux.in > > +++ b/util/grub.d/10_linux.in > > @@ -150,6 +150,7 @@ linux_entry () > > fi > > =20 > > echo " insmod gzio" | sed "s/^/$submenu_indentation/" > > + echo " if [ x\$grub_platform =3D xxen ]; then insmod xzio; insmod lz= opio; fi" | sed "s/^/$submenu_indentation/" > > =20 > > if [ x$dirname =3D x/ ]; then > > if [ -z "${prepare_root_cache}" ]; then > >=20 >=20 >=20 --Sig_/yvB88v.Pv+2tqOy2lRpgmZU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlSEjbAACgkQR6LMutpd94xnxQCggtXo24X3oJYrY7wkj7cuCd95 wSoAoJNeF6baHdLRXJ9lArCbc9Z9y9By =6pE0 -----END PGP SIGNATURE----- --Sig_/yvB88v.Pv+2tqOy2lRpgmZU--